Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:remove-link-test into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: 7ff975c272b12be073d11770203d291504c39ef0
Merged at revision: 7176580582dfec3433e0bbd0c85c9b89cb99e8f9
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:remove-link-test
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:network-manager/xenial/1.2.2
Diff against target: 42 lines (+24/-1)
2 files modified
run-tests.sh (+24/-0)
src/platform/tests/Makefile.am (+0/-1)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Simon Fels Approve
Matteo Croce (community) Approve
Review via email: mp+319036@code.launchpad.net

Commit message

Do not run test-link-linux tests

Do not run test-link-linux, as it crashes in the environment used to
build snaps by launchpad.

Description of the change

Do not run test-link-linux tests

Do not run test-link-linux, as it crashes in the environment used to
build snaps by launchpad.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/run-tests.sh b/run-tests.sh
2new file mode 100755
3index 0000000..b05bd9c
4--- /dev/null
5+++ b/run-tests.sh
6@@ -0,0 +1,24 @@
7+#!/bin/sh -ex
8+
9+SUDO=
10+if [ $(id -u) -ne 0 ]; then
11+ SUDO=sudo
12+fi
13+
14+# Install all necessary build dependencies in our bare build environment
15+$SUDO apt update
16+$SUDO apt install -y --force-yes \
17+ autoconf autoconf-archive pkg-config \
18+ libtool gcc g++ libc6-dev \
19+ intltool gtk-doc-tools libdbus-glib-1-dev libdbus-1-dev libiw-dev \
20+ libglib2.0-dev libnl-3-dev libnl-route-3-dev libnl-genl-3-dev \
21+ libnss3-dev libgnutls28-dev libgcrypt11-dev uuid-dev systemd \
22+ libsystemd-dev libudev-dev libgudev-1.0-dev libgirepository1.0-dev \
23+ gobject-introspection libglib2.0-doc libmm-glib-dev libndp-dev \
24+ libreadline-dev libnewt-dev dbus-test-runner isc-dhcp-client \
25+ python-dbus python-gi iptables ppp-dev
26+
27+./autogen.sh
28+./configure
29+make -j$(nproc)
30+make check
31diff --git a/src/platform/tests/Makefile.am b/src/platform/tests/Makefile.am
32index 5af4ce9..3878910 100644
33--- a/src/platform/tests/Makefile.am
34+++ b/src/platform/tests/Makefile.am
35@@ -125,7 +125,6 @@ TESTS = \
36 test-cleanup-linux \
37 test-general \
38 test-link-fake \
39- test-link-linux \
40 test-nmp-object \
41 test-route-fake \
42 test-route-linux

Subscribers

People subscribed via source and target branches