~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager:fix-cinterion-compilation

Last commit made on 2023-03-09
Get this branch:
git clone -b fix-cinterion-compilation https://git.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager
Only Alfonso Sanchez-Beato can upload to this branch. If you are Alfonso Sanchez-Beato please log in for upload directions.

Branch merges

Branch information

Name:
fix-cinterion-compilation
Repository:
lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager

Recent commits

cfd621e... by Alfonso Sanchez-Beato

plugins/cinterion: add missing static declaration

2e5d255... by System Enablement CI Bot <email address hidden>

Merge remote tracking branch feature/add-pls63-to-modem-manager

Merge-Proposal: https://code.launchpad.net/~kzapalowicz/snappy-hwe-snaps/+git/modem-manager/+merge/419247

Author: Konrad Zapałowicz <email address hidden>

cinterion: add support for PLS63 modem

The PLS63 is a drop-in replacement for PLS62 modem, however despite that
fact it has a different USB SoC. As a consequence enumarates
differently on the USB bus.

The modem-manager interface of snapd contains the udev rules for adding
type hints to USB devices. One of the recent updates includes the rules
for PLS63 modem.

This commit makes sure that the Modem Manager is using these type hints
so that it chosses the correct port for data.

See: https://github.com/snapcore/snapd/pull/11636

d5d2895... by System Enablement CI Bot <email address hidden>

Merge remote tracking branch feature/add-reset

Merge-Proposal: https://code.launchpad.net/~kzapalowicz/snappy-hwe-snaps/+git/modem-manager/+merge/438423

Author: Konrad Zapałowicz <email address hidden>

cinterion: implement reset

58a78b4... by Aleksander Morgado

cinterion: implement reset

f18f779... by Konrad Zapałowicz

cinterion: use port type hints on modem probe

The Cinterion plugin is using the output of the SQPORT? to guess which
ports can be used for AT commands and data connection.

Yet at the same time the udev adds port type hints to the Cinterion
modem upon its discovery.

This commit changes the initialization in a way that from now on it
skips sending SQPORT? when the port type hints are already assigned. By
doing this we make sure that the udev port type hints are being used
when they are available. In case they are not the initialization relies
on the outout of SQPORT? as it did do far.

This change is ported from the ModemManager upstream project so that the
PLS63 modem can be used on Ubuntu Core 16.

PLS63 is a drop-in replacement for the alredy supported PLS62 modem.
Albeit similar these modems use a different USB chips and as a
consequence the PLS63 modem is not enumerated in the same way as the
PLS62. This makes the ModemManager to a wrong port for the data. The
correct tagging of the ports is sorted out by snapd and this change is
making sure that the ModemManager is respecting these tags. See the
linked MRs:

See: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/782
See: https://github.com/snapcore/snapd/pull/11636

fbdba60... by "Theodore A. Roth" <email address hidden>

cinterion: Add support for PLSx3w modems

Signed-off-by: Theodore A. Roth <email address hidden>

cc696d7... by System Enablement CI Bot <email address hidden>

Merge remote tracking branch workaround-serial-pls62

Merge-Proposal: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager/+merge/369240

Author: Alfonso Sanchez-Beato <email address hidden>

bearer: workaround serial not responding in PLS62-W

Do not try to deactivate the PDP context for the Gemalto PLS62-W modem,
let NM do the job for us. The reason is that due to a modem firmware
bug, if the timing between pppd and us deactivating is unfortunate, the
port ends up in a state in which it is unusable. Note also that this LTE
modem cannot really disconnect while attached, so the AT command always
returns an error anyway. Fixes LP: #1829293.

ec7f5f8... by Alfonso Sanchez-Beato

cinterion: pls62: workaround serial not responding

Do not try to deactivate the PDP context for the Gemalto PLS62-W modem,
let NM do the job for us. The reason is that due to a modem firmware
bug, if the timing between pppd and us deactivating is unfortunate, the
port ends up in a state in which it is unusable. Note also that this LTE
modem cannot really disconnect while attached, so the AT command always
returns an error anyway.

To perform this, the disconnect 3gpp functions have been implemented
in the PLS62 bearer. Fixes LP: #1829293.

02ab1ea... by System Enablement CI Bot <email address hidden>

Merge remote tracking branch no-duplicated-traces

Merge-Proposal: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager/+merge/369086

Author: Alfonso Sanchez-Beato <email address hidden>

Ensure we do not get duplicated traces on journal

snapd redirectes all process output to the journal, while MM writes its
ouput to both syslog and to stderr. This provokes duplicated traces that
makes debugging harder than needed. We remove the openlog LOG_PERROR so
only the traces written directly by MM appear. Fixes LP: #1833524.

6faa13e... by Alfonso Sanchez-Beato

Ensure we do not get duplicated traces on journal

snapd redirectes all process output to the journal, while MM writes its
ouput to both syslog and to stderr. This provokes duplicated traces that
makes debugging harder than needed. We remove the openlog LOG_PERROR so
only the traces written directly by MM appear. Fixes LP: #1833524.