snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager:use-dict into ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:master

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager
  3. use-dict
  4. Merge into master
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 79ecc1f52b5b1a4b78ee18464e4af8919f3781b4
Merged at revision: a6689559d566c00df7b4033b95efdb0cb6e4ca1b
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager:use-dict
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:master
Diff against target: 19 lines (+4/-2)
1 file modified
snapcraft.yaml (+4/-2)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Review via email: mp+377650@code.launchpad.net

Commit message

Use 'interface' when defining plugs and slots

Define the plug/slot in the 'interface' field of a dictionary instead of
using directly the name. This workarounds a regression in snapcraft
3.9.5 (LP: #1859806).

Description of the change

Use 'interface' when defining plugs and slots

Define the plug/slot in the 'interface' field of a dictionary instead of
using directly the name. This workarounds a regression in snapcraft
3.9.5 (LP: #1859806).

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 79ecc1f52b5b1a4b78ee18464e4af8919f3781b4

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1283/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:79ecc1f52b5b1a4b78ee18464e4af8919f3781b4
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/460/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/491
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/491
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/491
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/491
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1283
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/1025
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1073/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/460/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 1d44384..f8822a4 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -13,10 +13,12 @@ base: core
6 grade: stable
7
8 slots:
9- service: modem-manager
10+ service:
11+ interface: modem-manager
12
13 plugs:
14- mmcli: modem-manager
15+ mmcli:
16+ interface: modem-manager
17
18 hooks:
19 configure:

Subscribers

People subscribed via source and target branches