snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager:optimize into ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:master

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager
  3. optimize
  4. Merge into master
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Tony Espy
Approved revision: 907bb5f9dabee7f5d827eae0157d8e6915e94940
Merged at revision: 0b9edf1a164cf476c7afa7cdc8fd317a8dd54b2a
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/modem-manager:optimize
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:master
Diff against target: 31 lines (+6/-0)
1 file modified
snapcraft.yaml (+6/-0)
Reviewer Review Type Date Requested Status
Tony Espy Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+354716@code.launchpad.net

Description of the change

Compile wiht optimizations turned on

Override snapcraft's CFLAGS to make sure -O2 is set and -g is not
(LP: #1791333).

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: fffea6afdc117b64d60f90cb187f10fbfd0d5ddb

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1113/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:fffea6afdc117b64d60f90cb187f10fbfd0d5ddb
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/278/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/321
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/321
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/321
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/321
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1113
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/856
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/891/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/278/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 907bb5f9dabee7f5d827eae0157d8e6915e94940

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1115/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:907bb5f9dabee7f5d827eae0157d8e6915e94940
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/280/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/323
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/323
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/323
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/323
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1115
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/858
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/893/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/280/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tony Espy (awe) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 5bfe311..cf7814e 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -74,6 +74,8 @@ parts:
6 configflags:
7 - --with-udev
8 - --libexecdir=/usr/lib/libmbim
9+ # Set explicitly CFLAGS until lp: #1791946 is solved
10+ - CFLAGS=-O2
11
12 build-packages:
13 - libglib2.0-dev
14@@ -100,6 +102,8 @@ parts:
15 configflags:
16 - --enable-mbim-qmux
17 - --libexecdir=/usr/lib/libqmi
18+ # Set explicitly CFLAGS until lp: #1791946 is solved
19+ - CFLAGS=-O2 -I$SNAPCRAFT_STAGE/include
20
21 build-packages:
22 - intltool
23@@ -132,6 +136,8 @@ parts:
24 - --with-polkit=no
25 - --enable-vala=no
26 - --enable-tests=yes
27+ # Set explicitly CFLAGS until lp: #1791946 is solved
28+ - CFLAGS=-O2 -I$SNAPCRAFT_PART_INSTALL/usr/include -I$SNAPCRAFT_PART_INSTALL/usr/include/x86_64-linux-gnu -I$SNAPCRAFT_STAGE/include
29
30 build-packages:
31 - intltool

Subscribers

People subscribed via source and target branches