Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/jenkins-jobs:use-pre-built-spread into ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: a1071f74f15693b6e4ac4f7b6d788057f8866f82
Merged at revision: 503b32a57e1fdf54494f9b6cdd6886a36f098200
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/jenkins-jobs:use-pre-built-spread
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master
Diff against target: 72 lines (+10/-40)
2 files modified
jobs/snap/snap-test.sh (+5/-20)
tools/test-snap.sh (+5/-20)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Approve
Konrad Zapałowicz (community) Approve
Review via email: mp+354469@code.launchpad.net

Description of the change

Use pre-built spread

Use a pre-built spread, as it is impossible to build it on xenial due
to golang libs becoming incompatible with 1.6

To post a comment you must log in.
Revision history for this message
Konrad Zapałowicz (kzapalowicz) :
review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/snap/snap-test.sh b/jobs/snap/snap-test.sh
2index 4982445..10cb331 100644
3--- a/jobs/snap/snap-test.sh
4+++ b/jobs/snap/snap-test.sh
5@@ -73,26 +73,11 @@ export TERM=linux
6 export DEBIAN_FRONTEND=noninteractive
7 export PATH=/build/bin:$PATH
8
9-# At this time it's necessary to build spread manually because
10-# the snapped version does not include the qemu/kvm backend.
11-# Once the snapped version includes this backend, then we can
12-# change the manual building of spread with making sure the snap
13-# package is installed.
14-export GOPATH=$(mktemp -d)
15-SPREAD_SRC=\$GOPATH/src/github.com/snapcore/spread
16-mkdir -p "\$SPREAD_SRC"
17-git clone https://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/spread "\$SPREAD_SRC"
18-go get -d -v github.com/snapcore/spread/... || true
19-
20-# This is to go back to a version of the crypto package that still supports go 1.6
21-# Eventually we should move to a newer golang version
22-cd "\$GOPATH"/go/src/golang.org/x/crypto/
23-git checkout 12dd70caea0268ac0d6c2707d0611ef601e7c64e
24-cd -
25-
26-go build github.com/snapcore/spread/cmd/spread
27-mkdir /build/bin
28-cp spread /build/bin
29+# Use a pre-built spread, as it is impossible to build it on xenial due
30+# to golang libs becoming incompatible with 1.6
31+git clone https://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/spread
32+mkdir -p /build/bin
33+cp spread/bin/spread /build/bin
34
35 git clone --depth 1 -b $CI_BRANCH git+ssh://$BOT_USERNAME@git.launchpad.net/~$LAUNCHPAD_TEAM/$LAUNCHPAD_PROJECT/+git/$CI_REPO /build/src
36 cd /build/src
37diff --git a/tools/test-snap.sh b/tools/test-snap.sh
38index 35f3070..3e6424b 100755
39--- a/tools/test-snap.sh
40+++ b/tools/test-snap.sh
41@@ -35,26 +35,11 @@ export TERM=linux
42 export DEBIAN_FRONTEND=noninteractive
43 export PATH=/build/bin:$PATH
44
45-# At this time it's necessary to build spread manually because
46-# the snapped version does not include the qemu/kvm backend.
47-# Once the snapped version includes this backend, then we can
48-# change the manual building of spread with making sure the snap
49-# package is installed.
50-export GOPATH=$(mktemp -d)
51-SPREAD_SRC=\$GOPATH/src/github.com/snapcore/spread
52-mkdir -p "\$SPREAD_SRC"
53-git clone https://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/spread "\$SPREAD_SRC"
54-go get -d -v github.com/snapcore/spread/... || true
55-
56-# This is to go back to a version of the crypto package that still supports go 1.6
57-# Eventually we should move to a newer golang version
58-cd "\$GOPATH"/go/src/golang.org/x/crypto/
59-git checkout 12dd70caea0268ac0d6c2707d0611ef601e7c64e
60-cd -
61-
62-go build github.com/snapcore/spread/cmd/spread
63-mkdir /build/bin
64-cp spread /build/bin
65+# Use a pre-built spread, as it is impossible to build it on xenial due
66+# to golang libs becoming incompatible with 1.6
67+git clone https://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/spread
68+mkdir -p /build/bin
69+cp spread/bin/spread /build/bin
70
71 git clone --depth 1 -b $BRANCH $REPO /build/src
72 cd /build/src

Subscribers

People subscribed via source and target branches