Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests:wifi-ap-cc-test into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

Proposed by Alfonso Sanchez-Beato on 2017-06-23
Status: Merged
Approved by: Jim Hodapp on 2017-06-27
Approved revision: 75cffedb9cc1106038b1bf06bc958a87bfe4c13b
Merged at revision: d8a8d8a77792c4261bb4558a500bbbc5eb7f2985
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests:wifi-ap-cc-test
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 30 lines (+22/-0)
1 file modified
wifi-ap/units/wifi-ap.pxu (+22/-0)
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve on 2017-06-27
System Enablement Bot continuous-integration Approve on 2017-06-27
Roberto Mier Escandon (community) Approve on 2017-06-26
Konrad Zapałowicz (community) code 2017-06-23 Approve on 2017-06-23
Review via email:

Description of the change

wifi-ap: add test for country code IE

To post a comment you must log in.
Konrad Zapałowicz (kzapalowicz) wrote :

LGTM but one small thing needs be added

review: Needs Fixing (code)

@Konrad, thanks for the comments, branch repushed after addressing comments.

Konrad Zapałowicz (kzapalowicz) wrote :


review: Approve (code)
Roberto Mier Escandon (rmescandon) wrote :

Just an inline suggestion/question

review: Needs Information
Jim Hodapp (jhodapp) wrote :

Just a minor grammar change.

review: Needs Fixing
Roberto Mier Escandon (rmescandon) wrote :


review: Approve

@Jim, thanks for the comments. Branch repushed.

Jim Hodapp (jhodapp) wrote :


review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/wifi-ap/units/wifi-ap.pxu b/wifi-ap/units/wifi-ap.pxu
index 229cd87..2f61369 100644
--- a/wifi-ap/units/wifi-ap.pxu
+++ b/wifi-ap/units/wifi-ap.pxu
@@ -189,3 +189,25 @@ _steps:
189 .189 .
191 Check that wifi.ssid=GadgetSnap191 Check that wifi.ssid=GadgetSnap
193id: wifi_ap/configuration/country_code
194category_id: wifi_ap
195plugin: manual
196depends: wifi_ap/connect/enable_ap
197_summary: WiFi AP sends the country code IE in beacon frames
199 Check if the WiFi AP sends the configured country code in beacon frames
201 1. Set the ISO/IEC 3166-1 code of the country you are in at the moment,
202 for instance
203 .
204 $ sudo wifi-ap.config set
205 .
206 2. Use a device with wifi to capture the beacon frames. You have to
207 turn on monitor mode for the wifi card to achieve this. See, for
208 instance
209 3. Capture the packets with tcpdump or wireshark
210 4. Check that the beacon frames from the SSID from the device where
211 you are testing wifi-ap contain the country code information element.
213 Check that IE contains the configure country code.


People subscribed via source and target branches