snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests:wifi-ap-cc-test into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests
  3. wifi-ap-cc-test
  4. Merge into master
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 75cffedb9cc1106038b1bf06bc958a87bfe4c13b
Merged at revision: d8a8d8a77792c4261bb4558a500bbbc5eb7f2985
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests:wifi-ap-cc-test
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 30 lines (+22/-0)
1 file modified
wifi-ap/units/wifi-ap.pxu (+22/-0)
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve
System Enablement Bot continuous-integration Approve
Roberto Mier Escandon (community) Approve
Konrad Zapałowicz (community) code Approve
Review via email: mp+326223@code.launchpad.net

Description of the change

wifi-ap: add test for country code IE

To post a comment you must log in.
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

LGTM but one small thing needs be added

review: Needs Fixing (code)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:4b29bc2ea381358086073323cd27fdf6c0875f15
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1696/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2256
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1603/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2618
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1779/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1696/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@Konrad, thanks for the comments, branch repushed after addressing comments.

Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

LGTM

review: Approve (code)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:04a1dc53006e68b3ef783e04b425db1292426727
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1697/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2257
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1605/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2619
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1781/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1697/rebuild

review: Approve (continuous-integration)
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Just an inline suggestion/question

review: Needs Information
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Just a minor grammar change.

review: Needs Fixing
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

lgtm

review: Approve
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@Jim, thanks for the comments. Branch repushed.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:75cffedb9cc1106038b1bf06bc958a87bfe4c13b
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1710/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2320
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1618/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2672
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1843/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1710/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/wifi-ap/units/wifi-ap.pxu b/wifi-ap/units/wifi-ap.pxu
2index 229cd87..2f61369 100644
3--- a/wifi-ap/units/wifi-ap.pxu
4+++ b/wifi-ap/units/wifi-ap.pxu
5@@ -189,3 +189,25 @@ _steps:
6 .
7 _verification:
8 Check that wifi.ssid=GadgetSnap
9+
10+id: wifi_ap/configuration/country_code
11+category_id: wifi_ap
12+plugin: manual
13+depends: wifi_ap/connect/enable_ap
14+_summary: WiFi AP sends the country code IE in beacon frames
15+_purpose:
16+ Check if the WiFi AP sends the configured country code in beacon frames
17+_steps:
18+ 1. Set the ISO/IEC 3166-1 code of the country you are in at the moment,
19+ for instance
20+ .
21+ $ sudo wifi-ap.config set wifi.country-code=ES
22+ .
23+ 2. Use a device with wifi to capture the beacon frames. You have to
24+ turn on monitor mode for the wifi card to achieve this. See, for
25+ instance https://sandilands.info/sgordon/capturing-wifi-in-monitor-mode-with-iw.
26+ 3. Capture the packets with tcpdump or wireshark
27+ 4. Check that the beacon frames from the SSID from the device where
28+ you are testing wifi-ap contain the country code information element.
29+_verification:
30+ Check that IE contains the configure country code.

Subscribers

People subscribed via source and target branches