Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/build-scripts:build-target into ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: 3bcc0869b9c4beb6c69a83ba8c5878e8ff03a413
Merged at revision: 233a79f80232c14cb3f6969fb48487baad20213e
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/build-scripts:build-target
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master
Diff against target: 20 lines (+2/-3)
1 file modified
jobs/generic-build-snap-worker (+2/-3)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Konrad Zapałowicz (community) Approve
Review via email: mp+328356@code.launchpad.net

Description of the change

snap-build: build on target branch
We were building the source branch instead of target + merged source
branch.

To post a comment you must log in.
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

Ack

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/generic-build-snap-worker b/jobs/generic-build-snap-worker
2index bb72cee..8a14d39 100755
3--- a/jobs/generic-build-snap-worker
4+++ b/jobs/generic-build-snap-worker
5@@ -37,13 +37,12 @@ if [ -n "$SOURCE_GIT_REPO" ]; then
6 fi
7
8 # Try to find the correct branch we need to build from. In the case that
9-# $SOURCE_GIT_REPO_BRANCH points us to an upstream component branch we
10+# $TARGET_GIT_REPO_BRANCH points us to an upstream component branch we
11 # will take master as the next suitable candidate.
12 CI_BRANCH=
13 SNAPCRAFT_YAML_PATH=
14-for branch in $SOURCE_GIT_REPO_BRANCH master ; do
15+for branch in $TARGET_GIT_REPO_BRANCH master ; do
16 git checkout $branch
17-
18 if [ -e snapcraft.yaml ]; then
19 SNAPCRAFT_YAML_PATH=snapcraft.yaml
20 elif [ -e snap/snapcraft.yaml ]; then

Subscribers

People subscribed via source and target branches