Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/bluez:20/fix-obexd-crash into ~snappy-hwe-team/snappy-hwe-snaps/+git/bluez:snap-20

[Alfonso Sanchez-Beato]

* Fix obexd crash (LP#1907498) - thanks Dan Dedrick
* Rebuild to fix CVE-2020-27348 (see https://ubuntu.com/security/notices/USN-4661-1)

* Fix obexd crash (LP#1907498) - thanks Dan Dedrick
* Rebuild to fix CVE-2020-27348 (see https://ubuntu.com/security/notices/USN-4661-1)

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Successfully build documentation, rev: cbd67788a108e08ba2e25b7895b82c27702e9b5c

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1375/

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:cbd67788a108e08ba2e25b7895b82c27702e9b5c
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/555/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/588
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/588
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/588
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/588
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1375
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/1117
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/1168/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/555/rebuild

review: Approve (continuous-integration)

diff --git a/patch/0005-obexd-don-t-free-environment-variable.patch b/patch/0005-obexd-don-t-free-environment-variable.patch
new file mode 100644
index 0000000..c66c68d
--- /dev/null
+++ b/patch/0005-obexd-don-t-free-environment-variable.patch
@@ -0,0 +1,31 @@
+From 8ef25c6ffef5786529b6dd292f6f5597c1dbfd4f Mon Sep 17 00:00:00 2001
+From: Dan Dedrick <[e-mail]>
+Date: Wed, 9 Dec 2020 11:57:36 -0500
+Subject: [PATCH] obexd: don't free environment variable
+
+Use g_strdup for option_root since it is expected to be freeable. When
+this was assigned to an environement variable it would then be passed to
+g_free and cause a crash because it wasn't memory that had been
+malloced.
+---
+ obexd/src/main.c | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/obexd/src/main.c b/obexd/src/main.c
+index 118b5a1a9..ddea9fbd5 100644
+--- a/obexd/src/main.c
++++ b/obexd/src/main.c
+@@ -285,7 +285,9 @@ int main(int argc, char *argv[])
+ 	}
+ 
+ 	if (option_root == NULL) {
+-		option_root = getenv("SNAP_USER_DATA");
++		const char * root_env = getenv("SNAP_USER_DATA");
++		if (root_env)
++			option_root = g_strdup(root_env);
+ 
+ 		if (!option_root)
+ 			option_root = g_build_filename(g_get_user_cache_dir(),
+-- 
+2.29.2
+