Code review comment for ~alfonsosanchezbeato/network-manager:test-ci

All looks good, however I have a question about your inclusion of resolvconf in the snap:

snap: add pppd and resolconf scripts to the snap

These files cannot be accessed from the snap anymore in UC18. Note that
the resolvconf scripts will be used only when installed in a UC16
system.

I think what you mean is that "these files" are no longer accessible from the core18 base snap.

Also instead of copying the scripts directly into the snap, a better approach would be to consume the resolvconf debian package via 'stage-packages'.