Merge lp:~alfonsosanchezbeato/media-hub/krillin-apparmor into lp:media-hub

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 44
Merged at revision: 46
Proposed branch: lp:~alfonsosanchezbeato/media-hub/krillin-apparmor
Merge into: lp:media-hub
Diff against target: 27 lines (+9/-0)
2 files modified
debian/changelog (+7/-0)
debian/usr.bin.media-hub-server (+2/-0)
To merge this branch: bzr merge lp:~alfonsosanchezbeato/media-hub/krillin-apparmor
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve
Review via email: mp+227297@code.launchpad.net

Commit message

Add more devices to apparmor configuration for Krillin.

Description of the change

Add more devices to apparmor configuration for Krillin. This fixes warning in logcat:

E/VDO_LOG (<pid>): eFuse dev open fail, limit to 720p

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

What are these accesses for?

As an aside, why is '/sys/bus/platform/drivers/** rw,' used (a very wide permission)?

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good, thanks. I saw that jdstrand approved of the added permissions on a security basis, so approving.

review: Approve
45. By Alfonso Sanchez-Beato

Fix 720p limit for OEM device

46. By Alfonso Sanchez-Beato

Add device to apparmor for OEM device

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-07-22 01:45:03 +0000
3+++ debian/changelog 2014-07-24 14:29:11 +0000
4@@ -1,3 +1,10 @@
5+media-hub (0.0.2+14.10.20140724-0ubuntu1) UNRELEASED; urgency=medium
6+
7+ * Fix 720p limit for OEM device
8+
9+ -- Alfonso Sanchez-Beato (email Canonical) <alfonso.sanchez-beato@canonical.com> Thu, 24 Jul 2014 15:28:24 +0200
10+
11+
12 media-hub (1.0.0+14.10.20140722-0ubuntu1) utopic; urgency=low
13
14 [ thomas-voss ]
15
16=== modified file 'debian/usr.bin.media-hub-server'
17--- debian/usr.bin.media-hub-server 2014-07-10 12:06:09 +0000
18+++ debian/usr.bin.media-hub-server 2014-07-24 14:29:11 +0000
19@@ -29,6 +29,8 @@
20 /dev/Vcodec rw,
21 /sys/bus/platform/drivers/** rw,
22 /{,android/}system/etc/mtk_omx_core.cfg r,
23+ /dev/devmap r,
24+ @{PROC}/mtk_mdp_cmdq r,
25
26 /sys/kernel/debug/tracing/trace_marker w,
27 /dev/ashmem rw,

Subscribers

People subscribed via source and target branches