Merge lp:~alextu/savilerow/test_custom_sound into lp:savilerow

[Alex Tu]

Branched from lp:~ethan.chang/savilerow/test_custom_sound and modified the latest test case to check the synchronization between dconf and AccountsService by D-Bus interface.

Already got ethan's approval, so would like to merge back from this branch instead.

Thanks.

[lp:~alextu/savilerow/test_custom_sound]

16. By Alex Tu on 2014-08-15

revised typo.

[Chris Wayne (cwayne)]

This is still just testing that the dconf key is set though, just in a different way. WHat we need to do is query accounts service via dbus, which is how the dialer app itself gets the file to play. From the asana card:

The ringtone/SMS sounds can be found with a dbus call to com.ubuntu.touch.AccountsService.Sound (defined in /usr/share/dbus-1/interfaces/com.ubuntu.touch.AccountsService.Sound.xml)

review: Needs Fixing

[Chris Wayne (cwayne)]

Im sorry! I stopped reading after I saw dconf, then went back and realized you do check the accounts service! Can you verify that this was tested on a device?

[Alex Tu (alextu)]

> Im sorry! I stopped reading after I saw dconf, then went back and realized
> you do check the accounts service! Can you verify that this was tested on a
> device?

It related to the issue: LP#1358080.
I verified it, this test script could read out the value by dbus call and dconf then compare them.

But the truth is current Dbus call always return "/usr/share/sounds/ubuntu/ringtones/Ubuntu.ogg" even dconf has been set to other audio file by custom.key.

This ring tone not working issue is out of the test script's control. :)

[Chris Wayne (cwayne)]

OK then, LGTM!

review: Approve

[Kyle Nitzsche (knitzsche)]

too old, closing.

Unmerged revisions

16. By Alex Tu on 2014-08-15

revised typo.

15. By Alex Tu on 2014-08-13

remove debug message

14. By Alex Tu on 2014-08-13

Add a test to check if the value of 'IncomingCallSound' and 'IncomingMessageSound' from DBus was synced with 'incoming-call-sound' and 'incoming-message-sound' from dconf.

Refer to https://app.asana.com/0/11854387211831/14240643122533/f

13. By Ethan Chang on 2014-08-11

*Create a test_custom_sound.py to verify ringtone and notification sound

12. By Alex Tu on 2014-08-07

Add a new custom feature: let user customize pin 6 apps on Apps scope. And also add test case in test_dconf.py

=== added file 'tests/api/test_custom_sound.py'
--- tests/api/test_custom_sound.py	1970-01-01 00:00:00 +0000
+++ tests/api/test_custom_sound.py	2014-08-15 15:04:12 +0000
@@ -0,0 +1,66 @@
+from autopilot.testcase import AutopilotTestCase
+import os
+import dbus
+from gi.repository import Gio
+
+#: Custom Ringtones/Notifications
+ringtone = "ring.mp3"
+notification = "sms.mp3"
+
+#: Ringtone/Notifications installation directory
+ringtones_path = "/custom/usr/share/sounds/ubuntu/stereo/"
+notifications_path = "/custom/usr/share/sounds/ubuntu/stereo/"
+
+class SoundsVerificationTest(AutopilotTestCase):
+    """
+    Downstream may ship pre-installed customized ringtone and notification
+    sound as part of the custom tarball. If so, they will be unpacked and
+    installed into /usr/share/sounds/
+
+    These tests verify that pre-installed ringtone and notification sounds
+    are properly installed 
+    """
+
+    def test_ringtones_customization_directory_exists(self):
+        """
+        Verify existence of target directories for pre-installed sounds.
+        """
+        #for ringtone in ringtones:
+        self.assertTrue(os.path.isfile(os.path.join(ringtones_path, ringtone)))
+
+    def test_notifications_customization_directory_exists(self):
+        """
+        Verify existence of target directories for pre-installed sounds.
+        """
+        #for notification in notifications:
+        self.assertTrue(os.path.isfile(os.path.join(notifications_path, notification)))
+
+    def test_custom_sounds_running(self):
+        """
+        This test ensures that the custom ringtone and notification which set in dconf database 
+        have been synced picked by AccountsService dbus object. 
+        """
+        settings = Gio.Settings('com.ubuntu.touch.sound')
+        dconf_ringtone = settings.get_string('incoming-call-sound')
+        dconf_notification = settings.get_string('incoming-message-sound')
+        
+        # get the setting in dbus object.
+        system_bus = dbus.SystemBus()
+        manager_proxy = system_bus.get_object('org.freedesktop.Accounts',
+                                              '/org/freedesktop/Accounts')
+        object_path = manager_proxy.FindUserById(
+            os.getuid(), dbus_interface='org.freedesktop.Accounts'
+        )
+        user_proxy = system_bus.get_object('org.freedesktop.Accounts', object_path)
+
+        try:
+            ringtone = user_proxy.Get('com.ubuntu.touch.AccountsService.Sound', 'IncomingCallSound',
+                dbus_interface=dbus.PROPERTIES_IFACE)
+            notification = user_proxy.Get('com.ubuntu.touch.AccountsService.Sound', 'IncomingMessageSound',
+                dbus_interface=dbus.PROPERTIES_IFACE)
+
+        except dbus.exceptions.DBusException as e:
+            print("Couldn't get %s: %s" % (setting, e), file=sys.stderr)
+
+        self.assertTrue((ringtone in dconf_ringtone and notification in dconf_notification), "value does not sync between dconf and the one from DBus") 
+