Merge ~alextu/plainbox-provider-pc-sanity:cvescan_cat_information_to_submission_html into plainbox-provider-pc-sanity:master

[Alex Tu]

[Alex Tu (alextu)]

to put the packages which needed a secure update to submission.html.

before this patch:
http://10.101.46.50:8080/job/sanity-3-testflinger-dell-bto-focal-fossa-201810-26535-staging/lastSuccessfulBuild/artifact/artifacts/submission.html#11-4-log

after this patch:
===========================[ Running Selected Jobs ]============================
--------------[ Running job 1 / 1. Estimated time left: unknown ]---------------
----------------------[ Scan if all CVEs are fixed well. ]----------------------
ID: com.canonical.certification::miscellanea/cvescan
Category: com.canonical.plainbox::miscellanea
Unable to create symlink s/var/tmp/checkbox-providers/plainbox-provider-pc-sanity/bin/check-turbostat-power-residency.sh -> /tmp/nest-rng64p9q.7efaeee37b98d807cf451d8f20f4d87ce4f6499235d9b9d43ac2f8bdb71613c0/check-turbostat-power-residency.sh: FileExistsError(17, 'File exists')
... 8< -------------------------------------------------------------------------
Cloning into 'sec-cvescan'...
/home/ubuntu/.local/bin/cvescan
⠋ Downloading Ubuntu vulnerability database..✅ Ubuntu vulnerability datbase successfully downloaded!
⠋ Scanning for vulnerable packages..✅ Scan complete!

/usr/bin/jq
[ERROR] You have some packages that need an update for CVE.
{
    "summary": {
        "ubuntu_release": "focal",
        "num_installed_packages": 1878,
        "num_cves": 1,
        "num_affected_packages": 2,
        "num_patchable_vulnerabilities": 2
    },
    "cves": {
        "CVE-2020-28374": {
            "url": "https://people.canonical.com/~ubuntu-security/cve/CVE-2020-28374",
            "packages": {
                "linux-libc-dev": {
                    "priority": "high",
                    "fixed_version": "5.4.0-62.70",
                    "repository": "Ubuntu Archive"
                },
                "linux-tools-common": {
                    "priority": "high",
                    "fixed_version": "5.4.0-62.70",
                    "repository": "Ubuntu Archive"
                }
            }
        }
    }
}
------------------------------------------------------------------------- >8 ---
Outcome: job failed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2021-01-16T17.13.24
==================================[ Results ]===================================
 ☒ : Scan if all CVEs are fixed well.

[Yuan-Chen Cheng (ycheng-twn)]

the patch and result look ok, however the extra "/usr/bin/jq" line is confusing.

Do you mind either change it to

> command -v jq > /dev/null || exit 1

or add

echo "Check if tool jq exists:"

before that line.

Let me know if you do mind.

review: Needs Fixing

[Yuan-Chen Cheng (ycheng-twn)]

LGTM

review: Approve

diff --git a/bin/cvescan.sh b/bin/cvescan.sh
index cd52cf9..5963d2d 100755
--- a/bin/cvescan.sh
+++ b/bin/cvescan.sh
@@ -51,10 +51,10 @@ get_cvescan_json() {
 
 parse_cvescan_json() {
     [ -n "$1" ] || exit 1
-    command -v jq || exit 1
+    command -v jq > /dev/null || exit 1
     if [ "$(jq -r '.summary.num_cves' < "$1")" != "0" ]; then
-        echo "You have some packages that need an update for CVE."
-        echo "Please check $1 for details"
+        echo "[ERROR] You have some packages that need an update for CVE."
+        cat "$1"
         exit 1
     fi
 }