Merge ~alextu/plainbox-provider-pc-sanity:sideload-changes-json into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: 0478aa3568eecfa079f3e06ff184890e2524d34e
Proposed branch: ~alextu/plainbox-provider-pc-sanity:sideload-changes-json
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 27 lines (+8/-0)
2 files modified
units/pc-sanity/pc-sanity-misc.pxu (+7/-0)
units/pc-sanity/pc-sanity.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Cyrus Lien Approve
Yuan-Chen Cheng (community) Approve
Review via email: mp+396040@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Tu (alextu) wrote :

given that we can easily sideload predefined providers by checkbox-run-plan --dev [1]

This side-load-changes.json is a file providing visibility about what test cases are changed by this sideloading.

Say, the changed test cases are from any MPs that are verified but waiting for upstream to merge it.

[1]:
 - https://git.launchpad.net/~oem-solutions-engineers/pc-enablement/+git/prepare-checkbox-sanity/tree/usr/sbin/checkbox-run-plan#n22
 - https://git.launchpad.net/~oem-solutions-engineers/pc-enablement/+git/prepare-checkbox-sanity/tree/usr/sbin/prepare-checkbox-sanity#n19

Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

LGTM as developments helper.

review: Approve
Revision history for this message
Cyrus Lien (cyruslien) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/pc-sanity/pc-sanity-misc.pxu b/units/pc-sanity/pc-sanity-misc.pxu
2index 1b51696..c61f448 100644
3--- a/units/pc-sanity/pc-sanity-misc.pxu
4+++ b/units/pc-sanity/pc-sanity-misc.pxu
5@@ -93,3 +93,10 @@ command: dpkg -l
6 _description:
7 attache log from dpkg -l
8
9+plugin: attachment
10+category_id: com.canonical.plainbox::miscellanea
11+id: miscellanea/side-load-changes
12+estimated_duration: 1.0
13+command: cat /var/tmp/checkbox-providers/*/side-load-changes.json || true
14+_description:
15+ attach what changed from sideloading.
16diff --git a/units/pc-sanity/pc-sanity.pxu b/units/pc-sanity/pc-sanity.pxu
17index 286af19..93c7194 100644
18--- a/units/pc-sanity/pc-sanity.pxu
19+++ b/units/pc-sanity/pc-sanity.pxu
20@@ -5,6 +5,7 @@ _description:
21 This test plan is for smoke test as sanity before release image.
22 include:
23 com.canonical.certification::miscellanea/dpkg-l
24+ com.canonical.certification::miscellanea/side-load-changes
25 com.canonical.certification::somerville-installation
26 com.canonical.certification::somerville/platform-meta-test
27 com.canonical.certification::misc/generic/grub_boothole

Subscribers

People subscribed via source and target branches