Merge ~alextu/plainbox-provider-pc-sanity:turbostat-dep-on-cpu-low-power-idle into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: 515e3ac426e217820b6f1fb758e63e1e6fa66f31
Proposed branch: ~alextu/plainbox-provider-pc-sanity:turbostat-dep-on-cpu-low-power-idle
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 45 lines (+12/-0)
2 files modified
units/pc-sanity/pc-sanity-power-consumption.pxu (+3/-0)
units/pc-sanity/pc-sanity.pxu (+9/-0)
Reviewer Review Type Date Requested Status
Kai-Chuan Hsieh Approve
Review via email: mp+394383@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Tu (alextu) wrote :

because a system failed on power-management/cpu-low-power-idle don't able to get package PC10.

So, it's meanless to check if it stays in PC10 long enough.

Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

It makes sense to me. Do you want to add dependency of power-management/system-low-power-idle for miscellanea/turbostate-s2i-power-residency?

review: Needs Information
Revision history for this message
Alex Tu (alextu) wrote :

good suggestion , but not necessary to add it.

Because SYS%LPI is the latest item of check-turbostat-power-residency.sh

GFX%rc6,Pkg%pc2,Pkg%pc3,Pkg%pc6,Pkg%pc7,Pkg%pc8,Pkg%pc9,Pk%pc10,SYS%LPI

It won't impact this test case calculating the residency of PC10.

Say, even s0ix not enabled, this test case provides the visibility of PC10.

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Okay, LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/pc-sanity/pc-sanity-power-consumption.pxu b/units/pc-sanity/pc-sanity-power-consumption.pxu
2index 6e6f534..f6d7716 100644
3--- a/units/pc-sanity/pc-sanity-power-consumption.pxu
4+++ b/units/pc-sanity/pc-sanity-power-consumption.pxu
5@@ -4,6 +4,7 @@ plugin: shell
6 category_id: com.canonical.plainbox::miscellanea
7 id: miscellanea/turbostate-s2i-power-residency
8 after: miscellanea/turbostate-long-idle-c10
9+depends: power-management/cpu-low-power-idle
10 user: root
11 command:
12 set -x
13@@ -16,6 +17,7 @@ _description:
14 plugin: shell
15 category_id: com.canonical.plainbox::miscellanea
16 id: miscellanea/turbostate-short-idle-c10
17+depends: power-management/cpu-low-power-idle
18 command:
19 set -x
20 report_folder="$HOME/submission-report-$(date +%Y%m%d%H%M)"
21@@ -40,6 +42,7 @@ _description:
22 plugin: shell
23 category_id: com.canonical.plainbox::miscellanea
24 id: miscellanea/turbostate-long-idle-c10
25+depends: power-management/cpu-low-power-idle
26 command:
27 set -x
28 report_folder="$HOME/submission-report-$(date +%Y%m%d%H%M)"
29diff --git a/units/pc-sanity/pc-sanity.pxu b/units/pc-sanity/pc-sanity.pxu
30index f623d52..87e3a45 100644
31--- a/units/pc-sanity/pc-sanity.pxu
32+++ b/units/pc-sanity/pc-sanity.pxu
33@@ -29,3 +29,12 @@ nested_part:
34 bootstrap_include:
35 device
36 graphics_card
37+
38+id: sleep-state-auto
39+_name: sleep-state-auto (Ubuntu Desktop)
40+unit: test plan
41+_description:
42+ This test plan collected all auto test related to sleep state.
43+include:
44+ com.canonical.certification::miscellanea/turbostate-long-idle-c10
45+ com.canonical.certification::miscellanea/turbostate-s2i-power-residency

Subscribers

People subscribed via source and target branches