Merge ~alextu/plainbox-provider-pc-sanity:turbostat-tips into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: 829e2edb4c7675014bdfed2144f05a554e9a386d
Proposed branch: ~alextu/plainbox-provider-pc-sanity:turbostat-tips
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 21 lines (+12/-1)
1 file modified
bin/check-turbostat-power-residency.sh (+12/-1)
Reviewer Review Type Date Requested Status
Leon Liao (community) Needs Information
jeremyszu (community) Approve
Kai-Chuan Hsieh Approve
Emily Chien Pending
OEM Solutions Group: Engineers Pending
Review via email: mp+393227@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

LGTM.

review: Approve
Revision history for this message
jeremyszu (os369510) wrote :

looks good so far.
Since I just confirmed the C10 is out-of HP scope.
I'll check the information whether is enough for me in the future if we need to deal with it.

review: Approve
Revision history for this message
Leon Liao (lihow731) wrote :

Pleas see my comment in line.

review: Needs Information

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/check-turbostat-power-residency.sh b/bin/check-turbostat-power-residency.sh
2index 58be121..ffdc02b 100755
3--- a/bin/check-turbostat-power-residency.sh
4+++ b/bin/check-turbostat-power-residency.sh
5@@ -92,4 +92,15 @@ for i in "${!turbostat[@]}"; do
6 fi
7 done
8
9-[ "$state" == "pass" ] || exit 1
10+if [ "$state" != "pass" ]; then
11+ echo "Your system not get Intel CPU PC10 or s0ix as expected, it could impact e-star compliance."
12+ echo "If the following test cases not run, that means your CPU architure or kernel driver not support PC10 or s0ix, please open bugs for HWE"
13+ echo " - power-management/cpu-low-power-idle"
14+ echo " - power-management/system-low-power-idle executed and passed."
15+ echo "Otherwise, please get PHM report to check which device blocking PC10 or s0ix and open bugs for HWE to check kernel modules"
16+ echo ""
17+ echo "reference:"
18+ echo " - https://01.org/blogs/qwang59/2020/linux-s0ix-troubleshooting"
19+ echo " - https://01.org/blogs/qwang59/2018/how-achieve-s0ix-states-linux"
20+ exit 1
21+fi

Subscribers

People subscribed via source and target branches