Merge ~alextu/plainbox-provider-pc-sanity:fix-build-error into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: fa3a658a80ec33efa2726be901589b75beddde5e
Proposed branch: ~alextu/plainbox-provider-pc-sanity:fix-build-error
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 13 lines (+1/-1)
1 file modified
debian/control (+1/-1)
Reviewer Review Type Date Requested Status
OEM Solutions Group: Engineers Pending
Review via email: mp+392446@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Tu (alextu) wrote :

verified build in container:
https://paste.ubuntu.com/p/wKkKx8RnYV/

Revision history for this message
jeremyszu (os369510) wrote :

@alextu hi, just a suggestion, plainbox-provider-checkbox is not in ubuntu-archive (at least not yet in focal). better to add the instructions to add source list in README file.

(I know it's a common sense for SWEs)

Revision history for this message
Alex Tu (alextu) wrote :

sure, will do that :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/control b/debian/control
2index 5c17129..f5ff613 100644
3--- a/debian/control
4+++ b/debian/control
5@@ -3,7 +3,7 @@ Section: utils
6 Priority: optional
7 Maintainer: Commercial Engineering <commercial-engineering@canonical.com>
8 Standards-Version: 3.9.7
9-Build-Depends: debhelper (>= 9), dh-modaliases
10+Build-Depends: debhelper (>= 9), dh-modaliases, intltool, python3-checkbox-ng, plainbox-provider-checkbox
11 Vcs-Browser: https://code.launchpad.net/~ville-team/ville/+git/plainbox-provider-pc-sanity
12
13 Package: plainbox-provider-pc-sanity

Subscribers

People subscribed via source and target branches