Merge ~alextu/plainbox-provider-pc-sanity:give-tips-to-proc-thermal-test into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Rejected
Rejected by: Alex Tu
Proposed branch: ~alextu/plainbox-provider-pc-sanity:give-tips-to-proc-thermal-test
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 28 lines (+5/-4)
1 file modified
units/pc-sanity/pc-sanity-thermal.pxu (+5/-4)
Reviewer Review Type Date Requested Status
Alex Tu Pending
Yuan-Chen Cheng Pending
Dirk Su Pending
Andy Chi Pending
koba Pending
Leon Liao Pending
OEM Solutions Group: Engineers Pending
Review via email: mp+392162@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Tu (alextu) wrote :

with this patch, the failed case would print this message :

ubuntu@u-Wyse-5070-Extended-Thin-Client:/var/tmp/checkbox-providers/plainbox-provider-pc-sanity/units$ checkbox-cli run com.canonical.certification::miscellanea/proc_thermal_driver
Using sideloaded provider: plainbox-provider-pc-sanity, version 1.20.0.dev0 from /var/tmp/checkbox-providers/plainbox-provider-pc-sanity
===========================[ Running Selected Jobs ]============================
--------------[ Running job 1 / 1. Estimated time left: unknown ]---------------
---------------------[ check if thermal driver installed. ]---------------------
ID: com.canonical.certification::miscellanea/proc_thermal_driver
Category: com.canonical.plainbox::miscellanea
... 8< -------------------------------------------------------------------------
++ date +%Y%m%d%H%M
+ report_folder=/home/ubuntu/submission-report-202010131436
+ mkdir -p /home/ubuntu/submission-report-202010131436
+ lspci -nnk
+ grep driver
+ grep proc_thermal
+ dmesg
+ lspci -nnk
+ lsmod
+ echo 'Please refer to LP: #1874008 and LP: #1851506 for the next steps.'
+ exit 1
Please refer to LP: #1874008 and LP: #1851506 for the next steps.
------------------------------------------------------------------------- >8 ---
Outcome: job failed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2020-10-13T06.36.35
==================================[ Results ]===================================
 ☒ : check if thermal driver installed.

Revision history for this message
Alex Tu (alextu) wrote :

with this patch, the passed case would print this message :

ubuntu@dell-bto-focal-fossa-201810-26535:/var/tmp$ checkbox-cli run com.canonical.certification::miscellanea/proc_thermal_driver
Using sideloaded provider: plainbox-provider-pc-sanity, version 1.20.0.dev0 from /var/tmp/checkbox-providers/plainbox-provider-pc-sanity
===========================[ Running Selected Jobs ]============================
--------------[ Running job 1 / 1. Estimated time left: unknown ]---------------
---------------------[ check if thermal driver installed. ]---------------------
ID: com.canonical.certification::miscellanea/proc_thermal_driver
Category: com.canonical.plainbox::miscellanea
... 8< -------------------------------------------------------------------------
++ date +%Y%m%d%H%M
+ report_folder=/home/ubuntu/submission-report-202010131439
+ mkdir -p /home/ubuntu/submission-report-202010131439
+ lspci -nnk
+ grep driver
+ grep proc_thermal
 Kernel driver in use: proc_thermal
+ exit 0
------------------------------------------------------------------------- >8 ---
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2020-10-13T06.39.36
==================================[ Results ]===================================
 ☑ : check if thermal driver installed.

Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[BOT]
$ cat plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal-summary.log
blame: .
badpkg: rules build failed with exit code 2
erroneous package: rules build failed with exit code 2
https://oem-share.canonical.com/share/lyoncore/artifacts/plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[BOT]
$ cat plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal-summary.log
blame: .
badpkg: rules build failed with exit code 2
erroneous package: rules build failed with exit code 2
https://oem-share.canonical.com/share/lyoncore/artifacts/plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[BOT]
$ cat plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal-summary.log
blame: .
badpkg: rules build failed with exit code 2
erroneous package: rules build failed with exit code 2
https://oem-share.canonical.com/partners/lyoncore/share/artifacts/plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal
Execute `curl -X POST http://10.102.135.31/api/v1/teams/self-contained/pipelines/plainbox-provider-pc-sanity/resources/merge-proposal-392162/check/webhook?webhook_token=merge-proposal-392162` within TW VPN to restart the test.

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
blame: .
badpkg: rules build failed with exit code 2
erroneous package: rules build failed with exit code 2

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
blame: .
badpkg: rules build failed with exit code 2
erroneous package: rules build failed with exit code 2

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

[autopkgtest]
blame: .
badpkg: rules build failed with exit code 2
erroneous package: rules build failed with exit code 2

https://oem-share.canonical.com/partners/lyoncore/share/artifacts/plainbox-provider-pc-sanity/plainbox-provider-pc-sanity-1.0.0-5af4e1c-in-linux-container-focal

Revision history for this message
Alex Tu (alextu) wrote :

give up this MP which not been merged for a long time.
Sorry, I mistakenly added some reviewers which supposed for another MP....

Unmerged commits

5af4e1c... by Alex Tu

give more tips for proc-thermal kernel driver testing.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/pc-sanity/pc-sanity-thermal.pxu b/units/pc-sanity/pc-sanity-thermal.pxu
2index f40149e..c02e0c4 100644
3--- a/units/pc-sanity/pc-sanity-thermal.pxu
4+++ b/units/pc-sanity/pc-sanity-thermal.pxu
5@@ -122,18 +122,19 @@ _description:
6
7 plugin: shell
8 category_id: com.canonical.plainbox::miscellanea
9-id: miscellanea/thermal
10+id: miscellanea/proc_thermal_driver
11 command:
12 set -x
13 report_folder="$HOME/submission-report-$(date +%Y%m%d%H%M)"
14 mkdir -p "$report_folder"
15 if lspci -nnk | grep driver | grep proc_thermal;then
16- true;
17+ exit 0;
18 else
19 dmesg > $report_folder/dmesg.log
20- lspci -nnk > $report_folder/dmesg.log
21+ lspci -nnk > $report_folder/lspci-nnk.log
22 lsmod > $report_folder/lsmod.log
23- false;
24+ echo "Please refer to LP: #1874008 and LP: #1851506 for the next steps."
25+ exit 1;
26 fi
27 _summary: check if thermal driver installed.
28 _description:

Subscribers

People subscribed via source and target branches