Provider for Plainbox - PC Sanity

Merge ~alextu/plainbox-provider-pc-sanity:refine-proc-thermal into plainbox-provider-pc-sanity:master

  1. Git
  2. lp:~alextu/plainbox-provider-pc-sanity
  3. refine-proc-thermal
  4. Merge into master
Proposed by Alex Tu
Status: Merged
Merged at revision: ffdafba996e296657d54b2c78d26f9274b5d5e25
Proposed branch: ~alextu/plainbox-provider-pc-sanity:refine-proc-thermal
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 42 lines (+7/-4)
2 files modified
units/pc-sanity/pc-sanity-thermal.pxu (+6/-3)
units/pc-sanity/pc-sanity.pxu (+1/-1)
Reviewer Review Type Date Requested Status
Leon Liao (community) Approve
OEM Solutions Group: Engineers Pending
Review via email: mp+391305@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alex Tu (alextu) wrote :

@Leo, could you please review if this MP give you enough information for you to take action when the issue happens like LP: #1896593

Revision history for this message
Leon Liao (lihow731) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/pc-sanity/pc-sanity-thermal.pxu b/units/pc-sanity/pc-sanity-thermal.pxu
2index 5dc49ea..1e87d5e 100644
3--- a/units/pc-sanity/pc-sanity-thermal.pxu
4+++ b/units/pc-sanity/pc-sanity-thermal.pxu
5@@ -80,7 +80,7 @@ _description:
6
7 plugin: shell
8 category_id: com.canonical.plainbox::miscellanea
9-id: miscellanea/thermal
10+id: miscellanea/proc_thermal
11 command:
12 set -x
13 report_folder="$HOME/submission-report-$(date +%Y%m%d%H%M)"
14@@ -92,10 +92,13 @@ command:
15 lspci -nnk > $report_folder/dmesg.log
16 lsmod > $report_folder/lsmod.log
17 false;
18+ echo "proc_thermal driver not be loaded."
19+ echo "It could caused by lake of ID in kernel like LP: #1874008."
20 fi
21-_summary: check if thermal driver installed.
22+_summary: Check if thermal driver be loaded.
23 _description:
24- check if thermal driver installed.
25+ Check if thermal driver be loaded. Which also checked if the CPU id be recognized by kernel.
26+ Thermal zone TCPU will not be created without this driver which also impact thermald operation.
27
28 plugin: shell
29 category_id: com.canonical.plainbox::miscellanea
30diff --git a/units/pc-sanity/pc-sanity.pxu b/units/pc-sanity/pc-sanity.pxu
31index 118a388..f623d52 100644
32--- a/units/pc-sanity/pc-sanity.pxu
33+++ b/units/pc-sanity/pc-sanity.pxu
34@@ -15,7 +15,7 @@ include:
35 com.canonical.certification::miscellanea/intel-cpu-thermal
36 com.canonical.certification::miscellanea/intel-x86-pkg-temp-thermal
37 com.canonical.certification::miscellanea/valid-thermal-zone-trip-points
38- com.canonical.certification::miscellanea/thermal
39+ com.canonical.certification::miscellanea/proc_thermal
40 com.canonical.certification::miscellanea/thermald
41 com.canonical.certification::miscellanea/dump_libsmbios_tokens
42 com.canonical.certification::miscellanea/dump_libsmbios_tokens_attachment

Subscribers

People subscribed via source and target branches