Merge ~alextu/plainbox-provider-pc-sanity:thermald_debug_tips into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: 8b9dbf6f24010f71b315257040e1e90b549a4457
Proposed branch: ~alextu/plainbox-provider-pc-sanity:thermald_debug_tips
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 18 lines (+6/-1)
1 file modified
units/pc-sanity/pc-sanity-thermal.pxu (+6/-1)
Reviewer Review Type Date Requested Status
Kai-Chuan Hsieh Pending
OEM Solutions Group: Engineers Pending
Review via email: mp+391030@code.launchpad.net

Commit message

update debug tips for bugs like LP: #1895776

To post a comment you must log in.
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

For thermald part, LGTM.

Revision history for this message
Alex Tu (alextu) wrote :

cleaned up non-related changes.
Sorry for that miss commit.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/pc-sanity/pc-sanity-thermal.pxu b/units/pc-sanity/pc-sanity-thermal.pxu
2index 264fe9a..5dc49ea 100644
3--- a/units/pc-sanity/pc-sanity-thermal.pxu
4+++ b/units/pc-sanity/pc-sanity-thermal.pxu
5@@ -105,7 +105,12 @@ command:
6 RETVAL=$?
7 if [ $RETVAL -ne 0 ];
8 then
9- journalctl -b -u thermald
10+ journalctl -b -u thermald > $PLAINBOX_SESSION_SHARE/journalctl.log
11+ echo "The log for thermald: $PLAINBOX_SESSION_SHARE/journalctl.log"
12+ grep -q "Unsupported cpu model" < $PLAINBOX_SESSION_SHARE/journalctl.log && \
13+ echo "Debugging Tips:"
14+ echo "Please check the upstream code(https://github.com/intel/thermal_daemon/blob/master/src/thd_engine.cpp) for the target id in id_table[] " && \
15+ echo "If the ID not there, then open a upstream bug like https://github.com/intel/thermal_daemon/issues/275 "
16 exit $RETVAL
17 fi
18 _summary: Check if thermald is active

Subscribers

People subscribed via source and target branches