Merge ~alextu/plainbox-provider-pc-sanity:somerville-check-chroot-log-failure into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: bcc20daa744393d13dbdcb55edc4c152d79b6f9c
Proposed branch: ~alextu/plainbox-provider-pc-sanity:somerville-check-chroot-log-failure
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 28 lines (+9/-0)
2 files modified
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-misc.pxu (+8/-0)
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Shih-Yuan Lee Approve
OEM Solutions Group: Engineers Pending
Review via email: mp+390068@code.launchpad.net

Commit message

pick somerville chroot.log checking from oem-qa-checkbox 6596762f

To post a comment you must log in.
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-misc.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-misc.pxu
2index e6a617e..8b83c23 100644
3--- a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-misc.pxu
4+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-misc.pxu
5@@ -67,3 +67,11 @@ _description: Suspend stress tests (with reboots)
6 include:
7 cpu_pkg_state_attachment
8 miscellanea/sosreport_attachment
9+
10+id: somerville-installation
11+category_id: com.canonical.plainbox::miscellanea
12+requires: package.name == 'dell-recovery'
13+plugin: shell
14+command:
15+ grep "(SUCCESS) Clean-Up .. Done" /var/log/installer/chroot.sh.log
16+_description: Check the result of the installation, from oem-qa-checkbox 6596762f
17diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
18index 9e4a885..29fbe05 100644
19--- a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
20+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
21@@ -4,6 +4,7 @@ unit: test plan
22 _description:
23 This test plan is for smoke test as sanity before release image.
24 include:
25+ com.canonical.certification::somerville-installation
26 com.canonical.certification::miscellanea/debsums
27 com.canonical.certification::miscellanea/turbostate-long-idle-c10
28 com.canonical.certification::miscellanea/intel-rapl

Subscribers

People subscribed via source and target branches