Merge ~alextu/plainbox-provider-pc-sanity:refine-package-pc10-testing into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: c1dd1ef8e07d2c44118c5bf675a916dac6a4e7d2
Proposed branch: ~alextu/plainbox-provider-pc-sanity:refine-package-pc10-testing
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 26 lines (+4/-2)
1 file modified
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-power-consumption.pxu (+4/-2)
Reviewer Review Type Date Requested Status
Kai-Chuan Hsieh Approve
OEM Solutions Group: Engineers Pending
Review via email: mp+388719@code.launchpad.net

Commit message

    wait longer to make sure cpu get into sleep and print more reference from debug sys file system

To post a comment you must log in.
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-power-consumption.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-power-consumption.pxu
2index ce90233..3e5cffd 100644
3--- a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-power-consumption.pxu
4+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-power-consumption.pxu
5@@ -32,7 +32,7 @@ command:
6 dpkg -s linux-tools-"$(uname -r)" || sudo apt-get install -y linux-tools-"$(uname -r)" || exit 1
7 dpkg -s xautomation || sudo apt-get install -y xautomation || exit 1
8 gsettings set org.gnome.desktop.session idle-delay 10
9- sleep 10
10+ sleep 30
11 for i in $(sudo turbostat --list | sed 's/,/ /g'); do
12 if [ -z "${i##*pc*}" ]; then
13 echo $i
14@@ -43,9 +43,11 @@ command:
15 fi
16 fi;
17 done;
18- sudo turbostat --num_iterations 20 --show "$COL" 2>&1 | tee "$report_folder"/turbostat-pkgpc-longidle.log
19+ sudo turbostat --num_iterations 30 --show "$COL" 2>&1 | tee "$report_folder"/turbostat-pkgpc-longidle.log
20 DISPLAY=:0 xte 'key Up'
21 gsettings set org.gnome.desktop.session idle-delay 0
22+ # cat additional message for reference
23+ sudo cat /sys/kernel/debug/pmc_core/package_cstate_show
24 # set false in the end when it failed so that test case be marked as failed.
25 ! (tail -n1 "$report_folder"/turbostat-pkgpc-longidle.log | grep "0.00$")
26 _summary: check if target machine can get cpu pkg c10 in long idle.

Subscribers

People subscribed via source and target branches