Merge ~alextu/plainbox-provider-pc-sanity:remove-turbostat-checking-for-short-idle into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: c21b04a6f8cb8b764ce70c8af9a6be10e1da65cd
Proposed branch: ~alextu/plainbox-provider-pc-sanity:remove-turbostat-checking-for-short-idle
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 30 lines (+3/-3)
2 files modified
debian/changelog (+3/-2)
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu (+0/-1)
Reviewer Review Type Date Requested Status
Yuan-Chen Cheng (community) Approve
Leon Liao Pending
OEM Solutions Group: Engineers Pending
Review via email: mp+383044@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

LGTM per my knowledge.

review: Approve
Revision history for this message
Rex Tsai (chihchun) wrote :

Hi, Alex, YC

In the future, I would like to see the justification in the changelog and merge propose to explain why the test case should be added or remoted.

I don't feel people will still remember the context after 6 months...

Regards
-Rex

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

As a log, per my knowledge: we only check c10 in long idle.

So it's so obvious to remove c10 check in short idle.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4009bb8..b279b71 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,10 +1,11 @@
6-plainbox-provider-pc-sanity (0.2.6ubuntu2) UNRELEASED; urgency=medium
7+plainbox-provider-pc-sanity (0.2.7) bionic; urgency=medium
8
9+ [ Alex Tu ]
10 * add gate_rste_raid case
11 * based on the meeting conclusion of 4/22, we need somerville version.
12 * to confirm the CPU package state in long idle
13
14- -- Alex Tu <alex.tu@canonical.com> Wed, 22 Apr 2020 15:49:10 +0800
15+ -- OEM Taipei Bot <oem-taipei-bot@canonical.com> Tue, 28 Apr 2020 06:07:31 +0000
16
17 plainbox-provider-pc-sanity (0.2.6ubuntu1) bionic; urgency=medium
18
19diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
20index f30c4ef..d5b723c 100644
21--- a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
22+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
23@@ -4,7 +4,6 @@ unit: test plan
24 _description:
25 This test plan is for smoke test as sanity before release image.
26 include:
27- com.canonical.certification::miscellanea/turbostate-short-idle-c10
28 com.canonical.certification::miscellanea/turbostate-long-idle-c10
29 com.canonical.certification::miscellanea/thermal
30 com.canonical.certification::miscellanea/dump_libsmbios_tokens

Subscribers

People subscribed via source and target branches