Provider for Plainbox - PC Sanity

Merge ~alextu/plainbox-provider-pc-sanity:gate_rste_raid into plainbox-provider-pc-sanity:master

  1. Git
  2. lp:~alextu/plainbox-provider-pc-sanity
  3. gate_rste_raid
  4. Merge into master
Proposed by Alex Tu
Status: Merged
Merged at revision: b956f93e2a53a1042219f1403631fcdd0aac2c3d
Proposed branch: ~alextu/plainbox-provider-pc-sanity:gate_rste_raid
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 41 lines (+27/-0)
2 files modified
debian/changelog (+6/-0)
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu (+21/-0)
Reviewer Review Type Date Requested Status
Shih-Yuan Lee Approve
Rex Tsai Pending
OEM Solutions Group: Engineers Pending
Review via email: mp+382731@code.launchpad.net

Description of the change

we don't support RSTe raid, so gate it based on https://docs.google.com/document/d/13G8VkaFB8W2ck-vtzu4OqkYFmi7-w0ooi6qNpxJLtPY/edit#

To post a comment you must log in.
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

Please follow https://launchpadlibrarian.net/468773053/hw-detect_1.117ubuntu8.debdiff to check the value of /sys/module/ahci/drivers/pci\:ahci/*/remapped_nvme.

review: Needs Fixing
Revision history for this message
Shih-Yuan Lee (fourdollars) :
review: Needs Fixing
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 91a3d8c..e77a5c2 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+plainbox-provider-pc-sanity (0.2.6ubuntu2) UNRELEASED; urgency=medium
7+
8+ * add gate_rste_raid case
9+
10+ -- Alex Tu <alex.tu@canonical.com> Wed, 22 Apr 2020 15:49:10 +0800
11+
12 plainbox-provider-pc-sanity (0.2.6ubuntu1) bionic; urgency=medium
13
14 * bump version
15diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu
16new file mode 100644
17index 0000000..5ef6585
18--- /dev/null
19+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu
20@@ -0,0 +1,21 @@
21+plugin: shell
22+category_id: com.canonical.plainbox::miscellanea
23+id: miscellanea/gate_rste_raid
24+command:
25+ set -x
26+ # copy from script https://launchpadlibrarian.net/468773053/hw-detect_1.117ubuntu8.debdiff
27+ for ahci_device in /sys/module/ahci/drivers/pci\:ahci/*/remapped_nvme
28+ do
29+ if [ -f "$ahci_device" ]; then
30+ ref_count="$(cat "$ahci_device")"
31+ if [ "$ref_count" -ge 1 ]; then
32+ echo "Intel RAID/RST mode detected."
33+ exit 1
34+ else
35+ echo "No Intel RAID/RST mode detected."
36+ fi
37+ fi
38+ done
39+_summary: to confirm the dell-recoery is what we expected.
40+_description:
41+ we don't support RSTe raid, so gate it based on https://docs.google.com/document/d/13G8VkaFB8W2ck-vtzu4OqkYFmi7-w0ooi6qNpxJLtPY/edit#

Subscribers

People subscribed via source and target branches