Merge ~alextu/plainbox-provider-pc-sanity:check-dell-recovery-ver into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: 91855ce043791e93563d68205f34b5d6b32dec7a
Proposed branch: ~alextu/plainbox-provider-pc-sanity:check-dell-recovery-ver
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 42 lines (+17/-0)
3 files modified
debian/changelog (+6/-0)
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu (+10/-0)
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Shih-Yuan Lee Approve
Leon Liao Pending
OEM Solutions Group: Engineers Pending
Review via email: mp+382727@code.launchpad.net

Description of the change

    check dell-recovery version based on the meeting conclusion of 4/22 meeting

    This test case is to prevent the case that the dell-recovery in Ubuntu
    archive override the one in oem image unexpectly.

    But the issue could be fixed if Canonical own the duty of dell-reocvery
    SRU. So, this case is here before the change of duty happens.

To post a comment you must log in.
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

Make sure dell-recovery is installed.

review: Needs Fixing
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 91a3d8c..582ed92 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+plainbox-provider-pc-sanity (0.2.6ubuntu2) UNRELEASED; urgency=medium
7+
8+ * based on the meeting conclusion of 4/22, we need somerville version.
9+
10+ -- Alex Tu <alex.tu@canonical.com> Wed, 22 Apr 2020 14:18:07 +0800
11+
12 plainbox-provider-pc-sanity (0.2.6ubuntu1) bionic; urgency=medium
13
14 * bump version
15diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu
16new file mode 100644
17index 0000000..98f2a60
18--- /dev/null
19+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu
20@@ -0,0 +1,10 @@
21+plugin: shell
22+category_id: com.canonical.plainbox::miscellanea
23+id: miscellanea/check_dell_recovery_version
24+requires: package.name == 'dell-recovery'
25+command:
26+ set -x
27+ dpkg -l | grep dell-recovery | grep ^ii | awk '{print $3}' | grep -q somerville
28+_summary: to confirm the dell-recoery is what we expected.
29+_description:
30+ based on the meeting conclusion of 4/22, we need somerville version before Mario agree Canonical take the duty of dell-recovery sru.
31diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
32index 42d14e7..64c9df8 100644
33--- a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
34+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
35@@ -9,6 +9,7 @@ include:
36 com.canonical.certification::miscellanea/dump_libsmbios_tokens
37 com.canonical.certification::miscellanea/dump_libsmbios_tokens_attachment
38 com.canonical.certification::miscellanea/check_i2c_hid
39+ com.canonical.certification::miscellanea/check_dell_recovery_version
40 nested_part:
41 com.canonical.certification::client-cert-auto
42 bootstrap_include:

Subscribers

People subscribed via source and target branches