Merge ~alextu/plainbox-provider-pc-sanity:add_severial_test_cases into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: b700482c4336310f950b865230ca9b401390d67b
Proposed branch: ~alextu/plainbox-provider-pc-sanity:add_severial_test_cases
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 41 lines (+24/-0)
2 files modified
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smbios.pxu (+20/-0)
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu (+4/-0)
Reviewer Review Type Date Requested Status
Yuan-Chen Cheng (community) Needs Fixing
Shih-Yuan Lee Approve
OEM Solutions Group: Engineers Pending
Review via email: mp+382286@code.launchpad.net

Description of the change

add cpu pc stat , thermal driver, dump libsmbios into smoke test plan.

To post a comment you must log in.
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

LGTM

review: Approve
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

I think use apt-file inside test case is overkill.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smbios.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smbios.pxu
2new file mode 100644
3index 0000000..579d76e
4--- /dev/null
5+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smbios.pxu
6@@ -0,0 +1,20 @@
7+plugin: shell
8+category_id: com.canonical.plainbox::miscellanea
9+id: miscellanea/dump_libsmbios_tokens
10+command:
11+ set -x
12+ [ -n "$(which apt-file)" ] || sudo apt-get install -y apt-file && sudo apt-get update
13+ sudo apt-get install -y $(apt-file search smbios-token-ctl | head -n1 |cut -d ':' -f1)
14+ sudo smbios-token-ctl -d 2>&1 | tee ${PLAINBOX_SESSION_SHARE}/libsmbios_tokens
15+_summary: dump libsmbios tokens
16+_description:
17+ please refer to https://trello.com/c/Vt0jzJin for detail
18+
19+plugin: attachment
20+category_id: com.canonical.plainbox::miscellanea
21+id: miscellanea/dump_libsmbios_tokens_attachment
22+depends: miscellanea/dump_libsmbios_tokens
23+estimated_duration: 1.0
24+command: [ -e ${PLAINBOX_SESSION_SHARE}/libsmbios_tokens ] && cat ${PLAINBOX_SESSION_SHARE}/libsmbios_tokens
25+_description:
26+ attache log, please refer to https://trello.com/c/Vt0jzJin for detail
27diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
28index 575fe02..ecf351f 100644
29--- a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
30+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-smoke-test.pxu
31@@ -4,6 +4,10 @@ unit: test plan
32 _description:
33 This test plan is for smoke test as sanity before release image.
34 include:
35+ com.canonical.certification::miscellanea/turbostate-short-idle-c10
36+ com.canonical.certification::miscellanea/thermal
37+ com.canonical.certification::miscellanea/dump_libsmbios_tokens
38+ com.canonical.certification::miscellanea/dump_libsmbios_tokens_attachment
39 nested_part:
40 com.canonical.certification::client-cert-auto
41 bootstrap_include:

Subscribers

People subscribed via source and target branches