Merge ~alextu/pc-enablement/+git/oem-gap-allow-list:more-tool-pkgs into ~oem-solutions-engineers/pc-enablement/+git/oem-gap-allow-list:master

Proposed by Alex Tu
Status: Merged
Merged at revision: 41ca9a682daa7f2b786c7d2018b0ab31a01aff6f
Proposed branch: ~alextu/pc-enablement/+git/oem-gap-allow-list:more-tool-pkgs
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-gap-allow-list:master
Diff against target: 14 lines (+6/-0)
1 file modified
testtools (+6/-0)
Reviewer Review Type Date Requested Status
Rex Tsai Approve
jeremyszu (community) Approve
Bin Li Pending
OEM Solutions Group: Engineers Pending
Review via email: mp+392703@code.launchpad.net

Commit message

$ apt-cache policy checkbox-ng fwts fwts-efi-runtime-dkms libfwts1 libfwtsacpica1 libfwtsiasl1
https://paste.ubuntu.com/p/BX5xXdzWxv/

To post a comment you must log in.
Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
jeremyszu (os369510) wrote :

Those package are necessary for stella and sutton as well.

Here is the output of $(apt show fwts) in focal (2020/10/25)

```
Package: fwts
Version: 20.03.00-0ubuntu1
Priority: optional
Section: universe/devel
Origin: Ubuntu
Maintainer: Firmware Testing Team <email address hidden>
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 1483 kB
Depends: libfwtsiasl1 (= 20.03.00-0ubuntu1), libfwtsacpica1 (= 20.03.00-0ubuntu1), libfwts1 (= 20.03.00-0ubuntu1), fwts-efi-runtime-dkms (= 20.03.00-0ubuntu1), libbsd0 (>= 0.0), libc6 (>= 2.14), libfdt1 (>= 1.5.1), libglib2.0-0 (>= 2.12.0), libjson-c4 (>= 0.13.1), pciutils
```

Since those packages will be added to this whitelist, which mean if engineers preload those package then them won't be found in our test scenario.

Add Bin for awareness.

and this MP should be reviewed by Rex as well.

review: Approve
Revision history for this message
jeremyszu (os369510) wrote :

BTW, Alex and I discussed the other implementation that is to detect the all dependencies and give the green light of them automatically to save our time.
but if the upstream package changed their dependencies to require a risky package then we won't awareness.
Finally, we agree to know the all discharged packages if the dependencies changed (when we add the new dependencies, we are able to review the latest dependencies to remove some packages from our whitelist to maintain it clearly).

Revision history for this message
Rex Tsai (chihchun) wrote :

The original idea is to screen out the packages that are not in the Ubuntu archive (ideally only main pocket)

so that checkbox-ng must be in the list, fwts-* are also great that we can capture them in the list.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/testtools b/testtools
2index d937e41..9dc1429 100644
3--- a/testtools
4+++ b/testtools
5@@ -13,3 +13,9 @@ prepare-checkbox-sanity
6 python3-checkbox-ng
7 python3-checkbox-support
8 python3-guacamole
9+checkbox-ng
10+fwts
11+fwts-efi-runtime-dkms
12+libfwts1
13+libfwtsacpica1
14+libfwtsiasl1

Subscribers

People subscribed via source and target branches