Merge ~alextu/pc-enablement/+git/oem-fix-misc-cnl-oem-image-helper:steps-to-support-ubuntu-recovery-injection into ~oem-solutions-engineers/pc-enablement/+git/oem-fix-misc-cnl-oem-image-helper:oem-fix-misc-cnl-oem-image-helper_fish

Proposed by Alex Tu
Status: Merged
Merged at revision: 4dfbd317b650848a2d2af6f9f6b98b445088318b
Proposed branch: ~alextu/pc-enablement/+git/oem-fix-misc-cnl-oem-image-helper:steps-to-support-ubuntu-recovery-injection
Merge into: ~oem-solutions-engineers/pc-enablement/+git/oem-fix-misc-cnl-oem-image-helper:oem-fix-misc-cnl-oem-image-helper_fish
Diff against target: 16 lines (+8/-0)
1 file modified
scripts/chroot-scripts/fish/01-oem-image-helper-install.sh (+8/-0)
Reviewer Review Type Date Requested Status
Yuan-Chen Cheng (community) Approve
Review via email: mp+402149@code.launchpad.net

This proposal supersedes a proposal from 2021-05-03.

To post a comment you must log in.
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

Change look good, however please share why this is needed.
This is not needed before, right?

review: Needs Fixing
Revision history for this message
Alex Tu (alextu) wrote :

So far, a lot of hacking for automation is based on dell-recovery with the foundation that /cdrom/debs be mounted during chroot scripts.

From the testing result of stella image, /cdrom/debs is not be as a local archive during all chroot scripts.

The easiest way to share those hacking for automation would be building up the foundation that /cdrom/debs be mounted during chroot scripts.

A quick testing with https://code.launchpad.net/~alextu/pc-enablement/+git/oem-scripts/+merge/402151 made a stella machine recovered with the hacking injected in recovery partition.

But so far, the part of skip oobe will stuck recovery process of Stella images which is something need to be fixed.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/scripts/chroot-scripts/fish/01-oem-image-helper-install.sh b/scripts/chroot-scripts/fish/01-oem-image-helper-install.sh
2index f3d9bcd..b45ab37 100755
3--- a/scripts/chroot-scripts/fish/01-oem-image-helper-install.sh
4+++ b/scripts/chroot-scripts/fish/01-oem-image-helper-install.sh
5@@ -1,3 +1,11 @@
6 #!/bin/bash
7+set -x
8+# if /cdrom/debs not in local archives, then prepare it(for ubuntu-recovery).
9+if [ -z "$(apt-cache search oem-fix-misc-cnl-oem-image-helper)" ]; then
10+ mkdir /tmp/cdrom_debs
11+ apt-ftparchive packages /cdrom/debs > /tmp/cdrom_debs/Packages
12+ echo 'deb [ trusted=yes ] file:/. /tmp/cdrom_debs/' >> /etc/apt/sources.list.d/$(basename $0)_$$.list
13+ sudo apt-get update
14+fi
15
16 apt-get install -y oem-fix-misc-cnl-oem-image-helper --allow-unauthenticated

Subscribers

People subscribed via source and target branches