Merge ~alexsander-souza/maas:lp1996204_fix_prometheus_labels into maas:master
Proposed by
Alexsander de Souza
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alexsander de Souza | ||||
Approved revision: | 986cef3e28fc281ee6aed5f6176310314ba784e7 | ||||
Merge reported by: | MAAS Lander | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~alexsander-souza/maas:lp1996204_fix_prometheus_labels | ||||
Merge into: | maas:master | ||||
Diff against target: |
37 lines (+12/-3) 1 file modified
src/maasserver/prometheus/middleware.py (+12/-3) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Grabowski | Approve | ||
MAAS Lander | Approve | ||
Review via email:
|
Commit message
normalize request path used as prometheus label
using the original requested path effectively tracks metrics per database object, not per endpoint as intended. Additionally it leads to huge number of histograms in the prometheus database, exceeding the 2GB limit after some time.
fixes LP#1996204
To post a comment you must log in.
UNIT TESTS fix_prometheus_ labels lp:~alexsander-souza/maas/+git/maas into -b master lp:~maas-committers/maas
-b lp1996204_
STATUS: FAILED maas-ci. internal: 8080/job/ maas-tester/ 2639/console 6fb9646a93c5036 58738d641f
LOG: http://
COMMIT: ceceed1d1bcaa4e