Created by Alex Murray on 2019-07-09 and last modified on 2019-07-09
Get this branch:
bzr branch lp:~alexmurray/whoopsie/whoopsie
Only Alex Murray can upload to this branch. If you are Alex Murray please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Alex Murray

Recent revisions

707. By Alex Murray on 2019-07-09

src/utils.c: Don't use strncpy where strcpy will suffice

The code is already very careful to allocate a buffer large enough for the
length of the filename extension so there is no need to use strncpy to
append this to the new filename - instead can just use strcpy.

With the previous code, whoopsie would FTBFS against gcc 8.3.0 due to the
following error as a result of this use of strncpy - so changing to strcpy
fixes the build:

In file included from /usr/include/string.h:494,
                 from src/utils.c:19:
In function ‘strncpy’,
    inlined from ‘change_file_extension’ at src/utils.c:92:5,
    inlined from ‘change_file_extension’ at src/utils.c:67:1:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
  106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils.c: In function ‘change_file_extension’:
src/utils.c:89:15: note: length computed here
   89 | ext_len = strlen (extension);
      | ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

706. By Alex Murray on 2019-07-09

src/whoopsie.c: Integer overflow when handling large crash dumps (LP: #1830863)

Don't use signed integer types for lengths to ensure large crash dumps do
not cause signed integer overflow


705. By Steve Langasek on 2019-07-01

releasing package whoopsie version 0.2.65

703. By Brian Murray on 2019-02-21

releasing package whoopsie version 0.2.64

702. By Brian Murray on 2019-02-21

When the package is being purged remove /var/lib/whoopsie/whoopsie-id.
(LP: #1816767)

701. By Brian Murray on 2018-11-21

releasing package whoopsie version 0.2.63

700. By Brian Murray on 2018-11-20

if the only thing in the .uploaded is the OOPS ID then OOPS ID seems unnecessary.

699. By Brian Murray on 2018-11-19

Write the reported OOPS ID to the .uploaded file. (LP: #1582470)

698. By Brian Murray on 2018-04-06

releasing package whoopsie version 0.2.62

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.