Merge ~alexmurray/ubuntu-qa-tools:unembargo-warn-security-updates-on-fridays into ubuntu-qa-tools:master

[Alex Murray]

[Alex Murray (alexmurray)]

Hmm this should probably also handle ESM PPAs etc.

review: Needs Fixing

[Alex Murray (alexmurray)]

Rebased the original commit on top of master and added support for checking Friday for ESM PPAs as well as the security pocket.

[Steve Beattie (sbeattie)]

This looks good to me, approving.

Extremely minor nits that absolutely do not block merging would be:

- use of magic numbers; it'd be nice not to have to remember that 4 == friday; not sure if the python libraries have a constant defined for this.

- a lot of our scripts do a lot o stuff inline, resuliting in long code sequences that an be overwhelming. This makes things slightly harder to understand and harder to write unit tests for. I don't necessarily think this added check is worth bothering with a separate function (expecially because most of the added bits is handling what to do if the check trips), but it's worth thinking about as we add things.

- if you're going to rebase or add commits after you've gone ahead and made a merge request, it's nice to add a reference link to the merge request in your commit message.

Thanks for the nice improvement!

review: Approve

[Alex Murray (alexmurray)]

Regarding the magic number - I can't find anything like an enum which defines this - but we could calculate it as:

time.strptime("Fri", "%a").tm_wday

although this seems more unwieldy to me.

Thanks for the review - I'll add a link in the merge-commit message to this. Cheers.

diff --git a/security-tools/unembargo b/security-tools/unembargo
index 73595e7..a78c826 100755
--- a/security-tools/unembargo
+++ b/security-tools/unembargo
@@ -137,6 +137,17 @@ def pending_milestone(ubuntu, release):
     return milestone
 
 
+# don't release security updates on Fridays
+if (opt.pocket == SECURITY_POCKET or opt.esm or opt.esm_apps or opt.esm_infra) and \
+   datetime.datetime.today().weekday() == 4:
+    print("WARNING: The security team has a policy of not releasing security updates "
+          "on Fridays.")
+    if not opt.force:
+        print("NOTE: To override this check and publish anyway please use the "
+              "--force.")
+        sys.exit(1)
+    else:
+        print("NOTE: Forcing the release of security updates on Fridays.")
 
 print("Loading Ubuntu Distribution ...")
 lp_version = "devel"