Merge ~alexmurray/ubuntu-dev-tools:fix-ppa-pull-lp-1938659 into ubuntu-dev-tools:master

[Alex Murray]

[Alex Murray (alexmurray)]

Oops forgot to specify in the merge request description - this is to resolve https://bugs.launchpad.net/ubuntu/+source/ubuntu-dev-tools/+bug/1938659

[Mattia Rizzolo (mapreri)]

perhaps you can use `yield from` instead of the loop? Also, is the same change needed in the private ppa cases visible in the same hunk?

Lastly, if changes are going to be needed, please include the bug reference (either LP:# or url) in the commit message.

[Alex Murray (alexmurray)]

Thanks for the hint re `yield from` - much nicer. This change is not needed in the private PPA case since that just returns a string, not a generator. Will redo the commit with the bug reference too. Cheers.

diff --git a/ubuntutools/archive.py b/ubuntutools/archive.py
index 4efac42..3d7561e 100644
--- a/ubuntutools/archive.py
+++ b/ubuntutools/archive.py
@@ -674,14 +674,14 @@ class PersonalPackageArchiveSourcePackage(UbuntuSourcePackage):
         if self.getArchive().private:
             yield self._private_ppa_url(name)
         else:
-            yield super()._source_urls(name)
+            yield from super()._source_urls(name)
 
     def _binary_urls(self, name, bpph):
         "Generator of URLs for name"
         if self.getArchive().private:
             yield self._private_ppa_url(name)
         else:
-            yield super()._binary_urls(name, bpph)
+            yield from super()._binary_urls(name, bpph)
 
 
 class UbuntuCloudArchiveSourcePackage(PersonalPackageArchiveSourcePackage):