~alexmurray/review-tools:dbus-app-activates-on-property-checking

Branch merges

Propose for merging

Rejected for merging into review-tools:master

Alex Murray: Disapprove on 2022-10-13

Samuele Pedroni: Pending requested 2022-10-11

James Henstridge: Pending requested 2022-10-11

Emilia Torino: Pending requested 2022-10-11

Diff: 622 lines (+262/-49)

5 files modified

check-names.list (+1/-0)
reviewtools/sr_common.py (+1/-2)
reviewtools/sr_lint.py (+68/-27)
reviewtools/tests/test_sr_lint.py (+112/-4)
tests/test.sh.expected (+80/-16)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

78e4a06... by Alex Murray on 2022-10-11

Update check-names.list and tests/test.sh.expected for new tests

Signed-off-by: Alex Murray <email address hidden>

2a4797c... by Alex Murray on 2022-10-11

sr_lint: Add support for dbus apps/activates-on property checking

The app bus-name property is essentially deprecated by upstream and instead the
activates-on property is used instead to specify a list of dbus slot names which
the app should activate on. Add support for checking this property is valid and
remove the old activatable dbus slot property which is not actually used by
snapd.

Signed-off-by: Alex Murray <email address hidden>

e892ae6... by Alex Murray on 2022-10-11

Add more overrides for core22-desktop base snap

Signed-off-by: Alex Murray <email address hidden>

77eb07d... by Alex Murray on 2022-10-11

overrides.py: Add overrides for Ubuntu Core desktop related snaps

Signed-off-by: Alex Murray <email address hidden>

afd089d... by Alex Murray on 2022-10-10

update changelog for release

Signed-off-by: Alex Murray <email address hidden>

b009d82... by Alex Lewontin on 2022-10-06

Fix custom-device attributes

custom-device interfaces slot-side files attribute should be a dict of
`read` and `write`, not a list (analogous to content's source slot-side
attribute)

Signed-off-by: Alex Lewontin <email address hidden>

4c8ed7f... by Alex Murray on 2022-09-26

Merge branch 'exec-stack-libx264-variant'

Signed-off-by: Alex Murray <email address hidden>

0c85012... by Emilia Torino on 2022-09-19

update changelog for release

Signed-off-by: Maria Emilia Torino <email address hidden>

7a62e21... by Emilia Torino on 2022-09-19

updating expected tests output after changes on slot side rules for plugs installation

Signed-off-by: Maria Emilia Torino <email address hidden>

baf8672... by Emilia Torino on 2022-09-19

Merge branch 'no-slot-side-rules-for-plug-installation'