View Git repositories
branches with status:
Name Status Last Modified Last Commit
lp:~alexmurray/whoopsie/whoopsie bug(Has a merge proposal) 1 Development 2019-07-09 03:51:19 UTC 2019-07-09
707. src/utils.c: Don't use strncpy where ...

Author: Alex Murray
Revision Date: 2019-07-09 02:14:40 UTC

src/utils.c: Don't use strncpy where strcpy will suffice

The code is already very careful to allocate a buffer large enough for the
length of the filename extension so there is no need to use strncpy to
append this to the new filename - instead can just use strcpy.

With the previous code, whoopsie would FTBFS against gcc 8.3.0 due to the
following error as a result of this use of strncpy - so changing to strcpy
fixes the build:

In file included from /usr/include/string.h:494,
                 from src/utils.c:19:
In function ‘strncpy’,
    inlined from ‘change_file_extension’ at src/utils.c:92:5,
    inlined from ‘change_file_extension’ at src/utils.c:67:1:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
  106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/utils.c: In function ‘change_file_extension’:
src/utils.c:89:15: note: length computed here
   89 | ext_len = strlen (extension);
      | ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

lp:indicator-sensors 1 Development 2019-03-21 06:38:10 UTC 2019-03-21
309. Merge pull request #21 from ginggs/pa...

Author: Alex Murray
Revision Date: 2019-03-21 06:38:10 UTC

Merge pull request #21 from ginggs/patch-1

Clean indicator-sensors.appdata.xml after build

lp:~alexmurray/indicator-sensors/packaging 1 Development 2014-10-14 02:04:17 UTC 2014-10-14
24. Don't break configure based build fro...

Author: Alex Murray
Revision Date: 2014-10-14 02:04:17 UTC

Don't break configure based build from tarball in favour of autogen for git

This should enable both the daily PPA and the release PPA
to use the same build infrastructure

13 of 3 results