Code review comment for lp:~alexlist/charms/trusty/swift-storage/nrpe-rebased

UOSCI bot says:
This MP triggered a test on the Ubuntu OSCI system. Here is a summary of results.

#459 swift-storage-next for alexlist mp231406
charm_unit_test

This build:
http://10.98.191.181:8080/job/charm_unit_test/459/

MP URL:
https://code.launchpad.net/~alexlist/charms/trusty/swift-storage/nrpe-rebased/+merge/231406

Proposed branch:
lp:~alexlist/charms/trusty/swift-storage/nrpe-rebased

Results summary:
    UNIT FAIL: unit-test failed

UNIT Results (max last 25 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.459:
 call('/srv/node', owner='swift', group='swift'),
 call('/etc/rsyncd.d', owner='root', group='root')]

======================================================================
FAIL: test_fetch_swift_rings (unit_tests.test_swift_storage_utils.SwiftStorageUtilsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/checkout/swift-storage/unit_tests/test_swift_storage_utils.py", line 99, in test_fetch_swift_rings
    self.assertEquals(wgets, self.check_call.call_args_list)
AssertionError: [call(['wget', 'http://someproxynode/rings/account.ring.gz', '-O', '/etc/swift/account.ring.gz']), call(['wget', 'http://someproxynode/rings/object.ring.gz', '-O', '/etc/swift/object.ring.gz']), call(['wget', 'http://someproxynode/rings/container.ring.gz', '-O', '/etc/swift/container.ring.gz'])] != [call(['wget', 'http://someproxynode/rings/account.ring.gz', '--retry-connrefused', '-t', '10', '-O', '/etc/swift/account.ring.gz']),
 call(['wget', 'http://someproxynode/rings/object.ring.gz', '--retry-connrefused', '-t', '10', '-O', '/etc/swift/object.ring.gz']),
 call(['wget', 'http://someproxynode/rings/container.ring.gz', '--retry-connrefused', '-t', '10', '-O', '/etc/swift/container.ring.gz'])]

Name Stmts Miss Cover Missing
-----------------------------------------------------
swift_storage_context 40 0 100%
swift_storage_hooks 70 16 77% 72, 77, 107-137
swift_storage_utils 111 8 93% 241-248
-----------------------------------------------------
TOTAL 221 24 89%
----------------------------------------------------------------------
Ran 31 tests in 1.384s

FAILED (failures=2)
make: *** [unit_test] Error 1

Ubuntu OSCI Jenkins is currently in development on a Canonical private network, but we plan to publish results to a public instance soon. Tests are triggered if the proposed branch rev changes, or if the MP is placed into "Needs review" status after being otherwise for >= 1hr. Human review of results is still recommended.
http://10.98.191.181:8080/