indicator-jenkins

Merge lp:~alexlewis-deactivatedaccount/indicator-jenkins/underscore_bug into lp:indicator-jenkins

  1. underscore_bug
  2. Merge into trunk
Proposed by Alex Lewis
Status: Needs review
Proposed branch: lp:~alexlewis-deactivatedaccount/indicator-jenkins/underscore_bug
Merge into: lp:indicator-jenkins
Diff against target: 12 lines (+1/-1)
1 file modified
menu.py (+1/-1)
To merge this branch: bzr merge lp:~alexlewis-deactivatedaccount/indicator-jenkins/underscore_bug
Reviewer Review Type Date Requested Status
Thomi Richards Pending
Review via email: mp+114673@code.launchpad.net

Description of the change

This is my attempt at a fix for Bug - https://bugs.launchpad.net/indicator-jenkins/+bug/1023915

This is quite literally my first bit of python I've ever done and the first time I've tried to contribute to a project on Launchpad so please be gentle :)

p.s. Apologies for the previous merge proposal, branch deletion and now this proposal. I had committed with my work email address rather than my personal one. So I deleted the branch, recommitted with the right email address, re-pushed the branch and consequently re-proposing the branch for merge. Sorry for any inconvenience.

To post a comment you must log in.

Unmerged revisions

50. By Alex Lewis

Underscores replaced with hyphen in job name

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'menu.py'
2--- menu.py 2012-04-06 20:43:37 +0000
3+++ menu.py 2012-07-12 16:06:25 +0000
4@@ -46,7 +46,7 @@
5 self.model_object.connect("notify::color", self.on_model_changed)
6 self.model_object.connect("notify::health-description", self.on_model_changed)
7 self.model_object.connect("notify::health-score", self.on_model_changed)
8- self.set_label(self.model_object.name)
9+ self.set_label((self.model_object.name).replace("_", "-"))
10 if self.model_object.color == "":
11 self.set_state_color("grey")
12 else:

Subscribers

No one subscribed via source and target branches