Merge lp:~alexlauni/unity-lens-music/play-after-queuing-834933 into lp:unity-lens-music

Proposed by Alex Launi
Status: Merged
Merged at revision: 47
Proposed branch: lp:~alexlauni/unity-lens-music/play-after-queuing-834933
Merge into: lp:unity-lens-music
Diff against target: 30 lines (+4/-3)
1 file modified
src/banshee-scope.vala (+4/-3)
To merge this branch: bzr merge lp:~alexlauni/unity-lens-music/play-after-queuing-834933
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+76281@code.launchpad.net

Description of the change

Changes the banshee exec string to banshee --play-enqueued

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

 review approve

Nice.

Pro tip: To make sure your debug message matches the exec array you
can do something like:

- debug (@"Spawning banshee --play $uri");
+ debug (@"Spawning '%s'", string.joinv(" ", exec));

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/banshee-scope.vala'
2--- src/banshee-scope.vala 2011-09-14 18:33:52 +0000
3+++ src/banshee-scope.vala 2011-09-20 20:05:18 +0000
4@@ -52,8 +52,8 @@
5 */
6 public Unity.ActivationResponse activate (string uri)
7 {
8- string[] exec = {"banshee", "--play"};
9-
10+ string[] exec = {"banshee", "--play-enqueued"};
11+
12 try {
13 if (Uri.parse_scheme (uri) == "album")
14 {
15@@ -76,13 +76,14 @@
16
17 exec += null;
18
19- debug (@"Spawning banshee --play $uri");
20+ debug (@"Spawning banshee --play-enqueued $uri");
21 Process.spawn_async (null,
22 exec,
23 null,
24 SpawnFlags.SEARCH_PATH,
25 null,
26 null);
27+
28 return new Unity.ActivationResponse (Unity.HandledType.HIDE_DASH);
29 } catch (SpawnError error) {
30 warning ("Failed to launch URI %s", uri);

Subscribers

People subscribed via source and target branches

to all changes: