Merge lp:~alexlauni/libunity/blacklist-crash-1029949 into lp:libunity
Proposed by
Alex Launi
Status: | Merged |
---|---|
Approved by: | Alex Launi |
Approved revision: | 198 |
Merged at revision: | 193 |
Proposed branch: | lp:~alexlauni/libunity/blacklist-crash-1029949 |
Merge into: | lp:libunity |
Diff against target: |
301 lines (+134/-69) 5 files modified
src/unity-sound-menu-mpris.vala (+18/-19) test/vala/Makefile.am (+60/-49) test/vala/Makefile.integration_tests (+0/-1) test/vala/blacklist-crash-1029949-test-case.vala (+44/-0) test/vala/test-mpris-backend-server.vala (+12/-0) |
To merge this branch: | bzr merge lp:~alexlauni/libunity/blacklist-crash-1029949 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Łukasz Zemczak | Approve | ||
Conor Curran | Pending | ||
Review via email:
|
Commit message
Fix crash when adding or removing players from the blacklist
Description of the change
Fixes segfault from non-null terminated array being passed to gsettings set_strv
To post a comment you must log in.
Built and tested with the test case - no crash or problems visible, no regressions as well. +1 for me. So I approve this in overall.
Just two things 'needing fixing'. First - is the printf necessary? It would be best if it was gone ;)
Second thing - could you actually add a test for this bug in this merge request? You could modify the vala test case that you have attached to the bug earlier. It's necessary that all things that can be actually tested land with tests.