Merge lp:~alexlauni/do/IStrictService into lp:do

[Alex Launi]

[Alex Launi (alexlauni)]

Adds a type of service called IStrictService that does not get lazy loaded, rather gets initialized when the service manager comes up. Most services can lazy load, but there are some cases (such as the PackageManager service that will be coming in a later merge) that cannot be lazy loaded and need to be created immediately.

[Robert Dyer (psybers)]

1. In the comment for 'InitializeIStrictServices' you mention looping to find IStatic (should be IStrictService?)

2. I don't like 'InitializeIStrictServices' as a method name. If you wind up deciding 'strict services' should be implemented via a different type hierarchy you will have to rename this method to mirror. I think 'InitializeStrictServices' is better (notice the lack of 'I', thus this method is not named after the type but rather after what it does).

review: Needs Fixing

[lp:~alexlauni/do/IStrictService]

1250. By Alex Launi on 2009-06-23

Fix a comment typo and make a method name cleaner as per PsyberS' review

[Alex Launi (alexlauni)]

Fixed

[Robert Dyer (psybers)]

review: Approve

[Jason Smith (jassmith)]

Looks good buddy, the part you noted as looking silly does indeed look silly... I wonder why they did it that way, but it is noted so no big deal.

review: Approve

=== modified file 'Do.Platform/Do.Platform.mdp'
--- Do.Platform/Do.Platform.mdp	2009-06-10 05:30:30 +0000
+++ Do.Platform/Do.Platform.mdp	2009-06-22 15:41:57 +0000
@@ -79,6 +79,7 @@
     <File name="src/Do.Platform/INetworkService.cs" subtype="Code" buildaction="Compile" />
     <File name="src/Do.Platform/NetworkStateChangedEventArgs.cs" subtype="Code" buildaction="Compile" />
     <File name="src/Do.Platform/Do.Platform.Default/NetworkService.cs" subtype="Code" buildaction="Compile" />
+    <File name="src/Do.Platform/Do.Platform.ServiceStack/IStrictService.cs" subtype="Code" buildaction="Compile" />
   </Contents>
   <References>
     <ProjectReference type="Gac" localcopy="True" refto="System, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />

=== modified file 'Do.Platform/Makefile.am'
--- Do.Platform/Makefile.am	2009-06-10 05:30:30 +0000
+++ Do.Platform/Makefile.am	2009-06-22 15:41:57 +0000
@@ -30,6 +30,7 @@
 	src/Do.Platform/Do.Platform.Preferences/PreferencesImplementation.cs \
 	src/Do.Platform/Do.Platform.ServiceStack/IInitializedService.cs \
 	src/Do.Platform/Do.Platform.ServiceStack/IService.cs \
+	src/Do.Platform/Do.Platform.ServiceStack/IStrictService.cs \
 	src/Do.Platform/ICoreService.cs \
 	src/Do.Platform/IEnvironmentService.cs \
 	src/Do.Platform/ILogService.cs \

=== added file 'Do.Platform/src/Do.Platform/Do.Platform.ServiceStack/IStrictService.cs'
--- Do.Platform/src/Do.Platform/Do.Platform.ServiceStack/IStrictService.cs	1970-01-01 00:00:00 +0000
+++ Do.Platform/src/Do.Platform/Do.Platform.ServiceStack/IStrictService.cs	2009-06-22 15:41:57 +0000
@@ -0,0 +1,31 @@
+//  %filename
+// 
+//   GNOME Do is the legal property of its developers. Please refer to the
+//   COPYRIGHT file distributed with this source distribution.
+// 
+//   This program is free software: you can redistribute it and/or modify
+//   it under the terms of the GNU General Public License as published by
+//   the Free Software Foundation, either version 3 of the License, or
+//   (at your option) any later version.
+//  
+//   This program is distributed in the hope that it will be useful,
+//   but WITHOUT ANY WARRANTY; without even the implied warranty of
+//   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+//   GNU General Public License for more details.
+//  
+//   You should have received a copy of the GNU General Public License
+//   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+using System;
+
+namespace Do.Platform
+{
+	
+	/// <summary>
+	/// If your service cannot be lazy loaded, and need initialization use this interface.
+	/// This will cause your service to be initialized with the Service manager.
+	/// </summary>
+	public interface IStrictService
+	{
+	}
+}

=== modified file 'Do.Platform/src/Do.Platform/Services.cs'
--- Do.Platform/src/Do.Platform/Services.cs	2009-06-10 05:30:30 +0000
+++ Do.Platform/src/Do.Platform/Services.cs	2009-06-22 15:41:57 +0000
@@ -19,6 +19,7 @@
 
 using System;
 using System.Linq;
+using System.Reflection;
 using System.Collections.Generic;
 
 using Mono.Addins;
@@ -60,6 +61,7 @@
 				throw new Exception ("AddinManager was initialized before Services.");
 			}
 			AddinManager.AddExtensionNodeHandler ("/Do/Service", OnServiceChanged);
+			InitializeIStrictServices ();
 		}
 
 		/// <summary>
@@ -229,5 +231,20 @@
 				return Enumerable.Empty<TService> ();
 			}
 		}
+		
+		/// <summary>
+		/// loops through the Property members of this class, and if it's an IStatic gets it's value.
+		/// This will in turn cause a LocateService call, and the appropriate service will be loaded.
+		/// </summary>
+		static void InitializeIStrictServices ()
+		{
+			foreach (PropertyInfo property in typeof (Services).GetProperties ()) {
+				Type returnType = property.PropertyType;
+				if (returnType.GetInterface ("Do.Platform.IStrictService") != null) {
+					// this looks stupid, but this is how you call the method on static classes.
+					property.GetValue (null, null);
+				}
+			}
+		}
 	}
 }