gdebi

Merge lp:~alexhenrie24/gdebi/fix-mime-type into lp:gdebi

  1. fix-mime-type
  2. Merge into trunk
Proposed by Alex Henrie
Status: Merged
Merged at revision: 487
Proposed branch: lp:~alexhenrie24/gdebi/fix-mime-type
Merge into: lp:gdebi
Diff against target: 53 lines (+7/-3)
4 files modified
GDebi/GDebiCommon.py (+1/-1)
data/gdebi-kde.desktop.in (+1/-1)
data/gdebi.desktop.in (+1/-1)
debian/changelog (+4/-0)
To merge this branch: bzr merge lp:~alexhenrie24/gdebi/fix-mime-type
Reviewer Review Type Date Requested Status
Michael Vogt Approve
Dimitri John Ledkov Pending
Luca Falavigna Pending
gdebi-developers Pending
Review via email: mp+263322@code.launchpad.net

Description of the change

xdg-open, used by Chromium and other applications, currently opens .deb files with /usr/lib/mime/debian-view instead of GDebi. It ignores GDebi because .deb files are detected as application/vnd.debian.binary-package, but gdebi.desktop only registers the nonstandard MIME types application/x-deb and application/x-debian-package. This is unfortunate because GDebi is far more user-friendly than debian-view.

I can't see a good reason to maintain support for the nonstandard MIME types. I think it would be best to drop them and instead register the MIME type that actually works.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a bunch! Its fine to remove the old mime-type, we might consider bringing it back if there are apps (like filemanagers) out there that use it to send it to gdebi. But for now I'm in favour of using only the real one. Thanks again!

review: Approve
Revision history for this message
Alex Henrie (alexhenrie24) wrote :

Thank you!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GDebi/GDebiCommon.py'
2--- GDebi/GDebiCommon.py 2014-04-22 07:44:07 +0000
3+++ GDebi/GDebiCommon.py 2015-06-30 06:36:33 +0000
4@@ -96,7 +96,7 @@
5 logging.debug("open failed with %s" % e)
6 mimetype=guess_type(file)
7 if (mimetype[0] != None and
8- mimetype[0] != "application/x-debian-package"):
9+ mimetype[0] != "application/vnd.debian.binary-package"):
10 self.error_header = _("'%s' is not a Debian package") % os.path.basename(file)
11 self.error_body = _("The MIME type of this file is '%s' "
12 "and can not be installed on this system.") % mimetype[0]
13
14=== modified file 'data/gdebi-kde.desktop.in'
15--- data/gdebi-kde.desktop.in 2013-08-03 23:06:56 +0000
16+++ data/gdebi-kde.desktop.in 2015-06-30 06:36:33 +0000
17@@ -7,7 +7,7 @@
18 Terminal=false
19 Type=Application
20 Categories=Qt;KDE;System;
21-MimeType=application/x-deb;application/x-debian-package;
22+MimeType=application/vnd.debian.binary-package;
23 OnlyShowIn=KDE;
24 InitialPreference=12
25 X-Ubuntu-Gettext-Domain=gdebi
26
27=== modified file 'data/gdebi.desktop.in'
28--- data/gdebi.desktop.in 2013-08-03 23:06:56 +0000
29+++ data/gdebi.desktop.in 2015-06-30 06:36:33 +0000
30@@ -7,7 +7,7 @@
31 Terminal=false
32 Type=Application
33 Categories=System;
34-MimeType=application/x-deb;application/x-debian-package;
35+MimeType=application/vnd.debian.binary-package;
36 NotShowIn=KDE;
37 X-Ubuntu-Gettext-Domain=gdebi
38 StartupNotify=true
39
40=== modified file 'debian/changelog'
41--- debian/changelog 2014-11-18 11:45:04 +0000
42+++ debian/changelog 2015-06-30 06:36:33 +0000
43@@ -2,6 +2,10 @@
44
45 * Use vte 2.91
46
47+ [ Alex Henrie ]
48+ * Use standard MIME type vnd.debian.binary-package so that xdg-open
49+ foo.deb will use gdebi
50+
51 -- Iain Lane <iain@orangesquash.org.uk> Tue, 18 Nov 2014 10:54:30 +0000
52
53 gdebi (0.9.5.5) unstable; urgency=medium

Subscribers

People subscribed via source and target branches

to status/vote changes: