Merge lp:~alexei-kornienko/testrepository/bug-1271133 into lp:~testrepository/testrepository/trunk

[Alexei Kornienko]

Partial-Fix for https://bugs.launchpad.net/testrepository/+bug/1271133

[Alexei Kornienko (alexei-kornienko)]

Requires https://github.com/testing-cabal/testtools/pull/77 to merge in subunit

[Alexei Kornienko (alexei-kornienko)]

s/subunit/testtools/

[Robert Collins (lifeless)]

The data is already available in in the file attachment 'import errors' from subunit - the reason for the inscrutable error from testr is that I hadn't finished gluing the layers together fully.

Whats needed, if you want to work on it - and please do! - is to take 'out', run it through subunit's parser to separate structured data from unstructured, and show all packets that are not test enumerations.

That will show the error strings from testtools cleanly, immediately.

review: Needs Fixing

[Robert Collins (lifeless)]

Hi! Could you repropose this to master - https://github.com/testing-cabal/testrepository? Thanks!

That said I believe I corrected this already in trunk.

Unmerged revisions

238. By Alexei Kornienko on 2014-02-10

Added stderr processing for testcommand.

Unescaped newline in cli output

Partial-Fix for https://bugs.launchpad.net/testrepository/+bug/1271133

237. By Robert Collins on 2013-11-04

Release 0.0.18.

=== modified file 'testrepository/testcommand.py'
--- testrepository/testcommand.py	2013-07-17 03:17:17 +0000
+++ testrepository/testcommand.py	2014-02-10 17:04:50 +0000
@@ -291,12 +291,16 @@
         try:
             self.ui.output_values([('running', list_cmd)])
             run_proc = self.ui.subprocess_Popen(list_cmd, shell=True,
-                stdout=subprocess.PIPE, stdin=subprocess.PIPE)
+                stdout=subprocess.PIPE, stdin=subprocess.PIPE, stderr=subprocess.PIPE)
             out, err = run_proc.communicate()
             if run_proc.returncode != 0:
-                raise ValueError(
-                    "Non-zero exit code (%d) from test listing."
-                    " stdout=%r, stderr=%r" % (run_proc.returncode, out, err))
+                message = "Non-zero exit code (%d) from test listing."
+                if err:
+                    raise ValueError((message + " stderr=%r") % (
+                        run_proc.returncode, err))
+                else:
+                    raise ValueError((message + " stdout=%r") % (
+                        run_proc.returncode, out))
             ids = parse_enumeration(out)
             return ids
         finally:

=== modified file 'testrepository/ui/cli.py'
--- testrepository/ui/cli.py	2013-04-13 16:40:43 +0000
+++ testrepository/ui/cli.py	2014-02-10 17:04:50 +0000
@@ -147,6 +147,7 @@
         # XX: Python2.
         if type(error_type) is bytes:
             error_type = error_type.decode('utf8')
+        error_type = error_type.replace("\\n", '\n')
         self._stderr.write(error_type + _u('\n'))
 
     def output_rest(self, rest_string):