subunit

Merge lp:~alexei-kornienko/subunit/bug-1271133 into lp:~subunit/subunit/trunk

  1. bug-1271133
  2. Merge into trunk
Proposed by Alexei Kornienko
Status: Rejected
Rejected by: Robert Collins
Proposed branch: lp:~alexei-kornienko/subunit/bug-1271133
Merge into: lp:~subunit/subunit/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
python/subunit/run.py (+1/-0)
To merge this branch: bzr merge lp:~alexei-kornienko/subunit/bug-1271133
Reviewer Review Type Date Requested Status
Robert Collins Disapprove
Review via email: mp+205626@code.launchpad.net

Description of the change

Partial-Fix for https://bugs.launchpad.net/testrepository/+bug/1271133

To post a comment you must log in.
Revision history for this message
Alexei Kornienko (alexei-kornienko) wrote :

Requires https://github.com/testing-cabal/testtools/pull/77 to merge in testtools

Revision history for this message
Robert Collins (lifeless) wrote :

This is inappropriate - the tunnelling through subunit gives machine processable data already for testr. Sorry for you having spent time coming up with the patch :(. Once testtools gives more data, it will be exposed to testr with no subunit changes needed.

review: Disapprove

Unmerged revisions

241. By Alexei Kornienko

Write error information to stderr

Partial-Fix for https://bugs.launchpad.net/testrepository/+bug/1271133

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'python/subunit/run.py'
2--- python/subunit/run.py 2013-11-30 02:01:09 +0000
3+++ python/subunit/run.py 2014-02-10 17:03:22 +0000
4@@ -69,6 +69,7 @@
5 result, errors = self._list(test)
6 if errors:
7 failed_descr = '\n'.join(errors).encode('utf8')
8+ sys.stderr.write(failed_descr)
9 result.status(file_name="import errors", runnable=False,
10 file_bytes=failed_descr, mime_type="text/plain;charset=utf8")
11 sys.exit(2)

Subscribers

People subscribed via source and target branches