Merge lp:~alex-meade/nova/run-tests-stop-flag-lp765069 into lp:~hudson-openstack/nova/trunk

Proposed by Alex Meade
Status: Merged
Approved by: Josh Kearney
Approved revision: 928
Merged at revision: 1045
Proposed branch: lp:~alex-meade/nova/run-tests-stop-flag-lp765069
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 20 lines (+2/-0)
2 files modified
Authors (+1/-0)
run_tests.sh (+1/-0)
To merge this branch: bzr merge lp:~alex-meade/nova/run-tests-stop-flag-lp765069
Reviewer Review Type Date Requested Status
Josh Kearney (community) Approve
Devin Carlen (community) Approve
Jay Pipes (community) Approve
Brian Waldon (community) Approve
Review via email: mp+59103@code.launchpad.net

Description of the change

Since run_tests.sh utilizes nose to run its tests, the -x, --stop flag works correctly for halting tests on the first failed test. The usage information for run_tests.sh now includes the --stop flag.

To post a comment you must log in.
Revision history for this message
Brian Waldon (bcwaldon) wrote :

Awesome. Functionality is already there, just needed to document it.

review: Approve
Revision history for this message
Jay Pipes (jaypipes) wrote :

Heh, nice :)

review: Approve
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :
Download full text (47.3 KiB)

The attempt to merge lp:~alex-meade/nova/run-tests-stop-flag-lp765069 into lp:nova failed. Below is the output from the failed tests.

AccountsTest
    test_account_create OK
    test_account_delete OK
    test_account_update OK
    test_get_account OK
AdminAPITest
    test_admin_disabled OK
    test_admin_enabled OK
APITest
    test_exceptions_are_converted_to_faults OK
Test
    test_authorize_token OK
    test_authorize_user OK
    test_bad_token OK
    test_bad_user_bad_key OK
    test_bad_user_good_key OK
    test_no_user OK
    test_token_expiry OK
TestFunctional
    test_token_doesnotexist OK
    test_token_expiry OK
TestLimiter
    test_authorize_token OK
LimiterTest
    test_limiter_custom_max_limit OK
    test_limiter_limit_and_offset OK
    test_limiter_limit_medium OK
    test_limiter_limit_over_max OK
    test_limiter_limit_zero OK
    test_limiter_negative_limit OK
    test_limiter_negative_offset OK
    test_limiter_nothing OK
    test_limiter_offset_bad OK
    test_limiter_offset_blank OK
    test_limiter_offset_medium OK
    test_limiter_offset_over_max OK
    test_limiter_offset_zero OK
ActionExtensionTest
    test_extended_action OK
    test_invalid_action OK
    test_invalid_action_body OK
ExtensionControllerTest
    test_get_by_alias OK
    test_index OK
ExtensionManagerTest
    test_get_resources OK
ResourceExtensionTest
    test_get_resources OK
    test_get_resources_with_controller OK
    test_no_extension_present OK
ResponseExtensionTest
    test_get_resources_with_mgr OK
    test_get_resources_with_stub_mgr OK
TestFaults
    test_400_fault_json OK
    test_400_fault_xml ...

928. By Alex Meade

Added myself to authors file

Revision history for this message
Josh Kearney (jk0) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Authors'
2--- Authors 2011-04-20 12:12:47 +0000
3+++ Authors 2011-04-27 04:57:18 +0000
4@@ -1,3 +1,4 @@
5+Alex Meade <alex.meade@rackspace.com>
6 Andy Smith <code@term.ie>
7 Andy Southgate <andy.southgate@citrix.com>
8 Anne Gentle <anne@openstack.org>
9
10=== modified file 'run_tests.sh'
11--- run_tests.sh 2011-04-20 20:27:33 +0000
12+++ run_tests.sh 2011-04-27 04:57:18 +0000
13@@ -6,6 +6,7 @@
14 echo ""
15 echo " -V, --virtual-env Always use virtualenv. Install automatically if not present"
16 echo " -N, --no-virtual-env Don't use virtualenv. Run tests in local environment"
17+ echo " -x, --stop Stop running tests after the first error or failure."
18 echo " -f, --force Force a clean re-build of the virtual environment. Useful when dependencies have been added."
19 echo " -p, --pep8 Just run pep8"
20 echo " -h, --help Print this usage message"