Code review comment for lp:~alex-idereal/bzr-eclipse/bzr-eclipse

On 02/19/2013 08:31 AM, Alexander Taler wrote:
> Alexander Taler has proposed merging lp:~alex-idereal/bzr-eclipse/bzr-eclipse into lp:bzr-eclipse.
>
> Requested reviews:
> bzr-eclipse developers (bzr-eclipse)
>
> For more details, see:
> https://code.launchpad.net/~alex-idereal/bzr-eclipse/bzr-eclipse/+merge/149207
>
> == New project creation wizard ==
>
> The primary change was to replace the two project creation wizards (checkout
> vs. branch) with a single one. The user experience was simplified by moving
> many options into an advanced tab and by providing clearer explanation of what
> is required. Additionally, the new wizard will discover Eclipse projects and
> add them automatically.
>
> == Other user facing changes ==
>
> Modify menu options for resolving conflicts to be more intuitive:
> + Rename "Resolve" to "Mark Resolved"
> + Add an "Edit Conflicts" option
>
> == Under the hood changes ==
>
> Add documentation on how to create an update site.
>
> Modify these Branch objects, to support other changes:
> + BranchFactory
> + LocalBranch
> + BranchLocationManager
>

Hi Alex,

I am planning to merge a branch I create based on
lp:~alex-idereal/bzr-eclipse/bzr-eclipse some time ago.
The branch is named
lp:~piastucki/bzr-eclipse/history-and-compare.<https://code.launchpad.net/%7Epiastucki/bzr-eclipse/history-and-compare>
I kept all your changes intact, but the BzrBranchLocator. I moved most
of the code from BzrBranchLocator to BranchLocation class
(bzr-java-lib), simplified BranchFactory as much as possible and removed
BzrBranchLocator. This way no changes are required in the existing code
yet the branch creation/validation code still looks better than before.
BTW, please let me know if you plan to work on further improvements in
project creation wizards.

Cheers,
Piotr