Merge lp:~alekasethm-deactivatedaccount/switchboard/fix-918424 into lp:~elementary-pantheon/switchboard/switchboard

Proposed by Paulo Galardi
Status: Rejected
Rejected by: Avi Romanoff
Proposed branch: lp:~alekasethm-deactivatedaccount/switchboard/fix-918424
Merge into: lp:~elementary-pantheon/switchboard/switchboard
Diff against target: 14 lines (+2/-2)
1 file modified
Switchboard/switchboard-app.vala (+2/-2)
To merge this branch: bzr merge lp:~alekasethm-deactivatedaccount/switchboard/fix-918424
Reviewer Review Type Date Requested Status
Avi Romanoff (community) Disapprove
Review via email: mp+94657@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Avi Romanoff (aroman) wrote :

This patch doesn't fix the issue at all. It just changes the minimum height of switchboard to something huge. On my 1336x768 screen, it takes up the entire screen.

The issue here is not the initial size, but the spacing policy for those boxes.

review: Disapprove

Unmerged revisions

181. By Seth Woods ,<email address hidden>>

Setup of Main window drawing is now 600x800 to make it not have weird padding.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Switchboard/switchboard-app.vala'
2--- Switchboard/switchboard-app.vala 2012-01-30 16:20:38 +0000
3+++ Switchboard/switchboard-app.vala 2012-02-25 15:16:19 +0000
4@@ -71,8 +71,8 @@
5 main_window.title = APP_TITLE;
6
7 // Set up window
8- main_window.height_request = 500;
9- main_window.width_request = 800;
10+ main_window.height_request = 800;
11+ main_window.width_request = 600;
12 main_window.window_position = Gtk.WindowPosition.CENTER;
13 main_window.destroy.connect(()=> shutdown());
14 setup_toolbar ();

Subscribers

People subscribed via source and target branches

to all changes: