Merge lp:~alecu/unity-scope-click/explicit-gcc-version into lp:unity-scope-click/devel

[Alejandro J. Cura]

Use g++ 4.9 explicitly to protect from ABI breaks in libstdc++

Use g++ 4.9 explicitly to protect from ABI breaks in libstdc++

This branch shamelessly borrows from lp:~charlesk/indicator-datetime/make-gcc-version-explicit

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:303
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-ci/151/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-amd64-ci/126/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-armhf-ci/125/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-i386-ci/125/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-team-unity-scope-click-devel-ci/151/rebuild

review: Needs Fixing (continuous-integration)

[Dimitri John Ledkov (xnox)]

This will cause cross-compilation to fail. As there is no way to correctly enforce cross-compiler yet (build-profiles are not fully implemented yet) please change:

g++-4.9

to

g++-4.9:native

This will achieve fully desired goals during native compilation, without breaking cross-compilation.

review: Needs Fixing

[lp:~alecu/unity-scope-click/explicit-gcc-version]

304. By Alejandro J. Cura on 2014-06-26

Fixes requested in review

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:304
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-ci/152/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-amd64-ci/127/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-armhf-ci/126/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-i386-ci/126/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-team-unity-scope-click-devel-ci/152/rebuild

review: Needs Fixing (continuous-integration)

[lp:~alecu/unity-scope-click/explicit-gcc-version]

305. By Alejandro J. Cura on 2014-06-26

Missing hyphen

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:305
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-ci/154/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-amd64-ci/129/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-armhf-ci/128/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-i386-ci/128/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-team-unity-scope-click-devel-ci/154/rebuild

review: Needs Fixing (continuous-integration)

[Dimitri John Ledkov (xnox)]

I'm not quite sure what's wrong, but :native build-dependencies are supported by the archive and all the landing tools we use.

[Colin Watson (cjwatson)]

I disagree with the instruction to use g++-4.9:native. It doesn't make logical sense (we need a compiler that targets the host architecture), and the issue of compiler dependencies for cross-building is one that we need to fix centrally in sbuild or similar; we shouldn't be trying to work around it in individual packages like this.

Unmerged revisions

305. By Alejandro J. Cura on 2014-06-26

Missing hyphen

304. By Alejandro J. Cura on 2014-06-26

Fixes requested in review

303. By Alejandro J. Cura on 2014-06-26

make g++ 4.9 explicit

=== modified file 'debian/control'
--- debian/control	2014-06-23 15:00:28 +0000
+++ debian/control	2014-06-26 18:16:41 +0000
@@ -1,9 +1,12 @@
 Source: unity-scope-click
 Section: x11
 Priority: optional
+# g++-4.9: since we use c++11 features, explicitly select a g++ version
+#          to protect from ABI breaks in libstdc++
 Build-Depends: cmake (>= 2.8.10),
                debhelper (>= 9),
                dh-translations,
+               g++-4.9:native,
                google-mock,
                intltool,
                libboost-locale-dev,

=== modified file 'debian/rules'
--- debian/rules	2014-04-04 16:40:49 +0000
+++ debian/rules	2014-06-26 18:16:41 +0000
@@ -1,4 +1,10 @@
 #!/usr/bin/make -f
+include /usr/share/dpkg/default.mk
+
+# Explicitly selecting a G{CC,++}-version here to avoid accidental
+# ABI breaks introduced by toolchain updates.
+export CC=$(DEB_HOST_GNU_TYPE)-gcc-4.9
+export CXX=$(DEB_HOST_GNU_TYPE)-g++-4.9
 
 DH_CMAKE_BUILD_DIR=obj-${DEB_BUILD_GNU_TYPE}