Merge lp:~alecu/unity-scope-click/add-readmes into lp:unity-scope-click/devel

Proposed by Alejandro J. Cura
Status: Merged
Approved by: dobey
Approved revision: 261
Merged at revision: 259
Proposed branch: lp:~alecu/unity-scope-click/add-readmes
Merge into: lp:unity-scope-click/devel
Diff against target: 86 lines (+77/-0)
2 files modified
HACKING (+61/-0)
README (+16/-0)
To merge this branch: bzr merge lp:~alecu/unity-scope-click/add-readmes
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
dobey (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+219731@code.launchpad.net

Commit message

Add README and HACKING files

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
dobey (dobey) wrote :

Is there any particularly good reason to reproduce the short version of the license, and the Copyright info, in the README? I think we shouldn't be putting that here, as the COPYING and source files describe the license and any copyright well enough already.

review: Needs Information
Revision history for this message
Leo Arias (elopio) wrote :

I tried all the steps and they work, so +1 for my side. I don't have a strong opinion on the License section of the README. I kind of like it, but I couldn't give good reasons to dobey.

review: Approve
Revision history for this message
Leo Arias (elopio) wrote :

Please add the steps to generate the coverage report.

install gcovr and lcov
cmake .. -DCMAKE_BUILD_TYPE=coverage
make coverage-html

The html will be left on the coveragereport directory.

Revision history for this message
Leo Arias (elopio) :
review: Needs Fixing
Revision history for this message
Alejandro J. Cura (alecu) wrote :

I used Mir's README and HACKING files as a base, that's where I took the license paragraphs:
http://bazaar.launchpad.net/~mir-team/mir/utopic/view/head:/README.md

260. By Alejandro J. Cura

Fix copyright line, add info on how to run coverage testing.

261. By Alejandro J. Cura

Remove License from README, added paragraph that points to other files

Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Leo Arias (elopio) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'HACKING'
2--- HACKING 1970-01-01 00:00:00 +0000
3+++ HACKING 2014-05-16 18:54:57 +0000
4@@ -0,0 +1,61 @@
5+unity-scope-click hacking guide
6+===============================
7+
8+Getting unity-scope-click
9+-------------------------
10+
11+To get the main development branch of unity-scope-click:
12+
13+ $ bzr branch lp:unity-scope-click/devel
14+
15+
16+Getting dependencies
17+--------------------
18+
19+To succesfully build the scope there are a few packages required:
20+
21+ $ sudo apt-get build-dep unity-scope-click
22+
23+
24+Building the scope
25+------------------
26+
27+This scope is built using cmake. Here's an example on how to build it:
28+
29+ $ mkdir build
30+ $ cd build
31+ $ cmake ..
32+ $ make -j 8
33+
34+
35+Running the unit tests
36+----------------------
37+
38+ $ make check
39+
40+Or, if you want to run the tests under valgrind:
41+
42+ $ make check-valgrind
43+
44+
45+Running the scope
46+-----------------
47+
48+You will usually run the scope inside a unity8 session, but when developing
49+a good way to test it is with unity-scope-tool. Inside the build directory do:
50+
51+ $ mkdir clickscope
52+ $ (cd clickscope;ln -s ../scope/click/libclickscope.so .; ln -s ../data/clickscope.ini .)
53+ $ U1_DEBUG=true unity-scope-tool clickscope/clickscope.ini
54+
55+
56+Running the coverage tests
57+--------------------------
58+
59+To run the coverage tests you'll need to install the gcovr and lcov packages.
60+Then you need to compile with coverage enabled, like this:
61+
62+ $ cmake .. -DCMAKE_BUILD_TYPE=coverage
63+ $ make coverage-html
64+
65+The html will be left on the coveragereport directory.
66
67=== modified file 'README'
68--- README 2013-07-18 18:25:34 +0000
69+++ README 2014-05-16 18:54:57 +0000
70@@ -0,0 +1,16 @@
71+Readme
72+======
73+
74+unity-scope-click - Click Packages Scope for Unity
75+--------------------------------------------------
76+
77+This scope shows the list of installed applications, and the list of
78+applications available to download from the appstore webservice.
79+To authenticate downloads, this scope uses Ubuntu Online Accounts to
80+get credentials for the logged in user.
81+Since scopes are short lived, ubuntu-download-manager is used to do
82+the actual download.
83+
84+You can find information on how to compile and run this program in
85+the HACKING file, and you can find licensing information in the
86+COPYING file.

Subscribers

People subscribed via source and target branches

to all changes: