Merge lp:~alecu/ubuntuone-windows-installer/tunnel-use-console into lp:ubuntuone-windows-installer

Proposed by Alejandro J. Cura
Status: Merged
Approved by: Brian Curtin
Approved revision: 119
Merged at revision: 119
Proposed branch: lp:~alecu/ubuntuone-windows-installer/tunnel-use-console
Merge into: lp:ubuntuone-windows-installer
Diff against target: 24 lines (+3/-4)
1 file modified
scripts/setup.py (+3/-4)
To merge this branch: bzr merge lp:~alecu/ubuntuone-windows-installer/tunnel-use-console
Reviewer Review Type Date Requested Status
Brian Curtin (community) Approve
dobey (community) Approve
Review via email: mp+108279@code.launchpad.net

Commit message

- Syncdaemon expects proxy-tunnel to output port info to stdout. (LP: #1006899)

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Brian Curtin (brian.curtin) wrote :

I've built an installer for this at http://ubuntuone.com/1y4nTEL7pEcRJ8TgOg3MqW but as you'll notice, this change causes the tunnel to show a command window.

review: Needs Fixing
Revision history for this message
Manuel de la Peña (mandel) wrote :

It might be a super dirty trick but can we use a batch that launches the .exe and hides the need of the windows? I found a small example using start: http://stackoverflow.com/questions/507347/hide-command-window-of-bat-file-that-executes-another-exe-file

As I said, just a dirty trick :(

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Hi Brian, thanks for your review.

Please rebuild the installer with this patch for twisted:
lp:~alecu/twisted/dont-open-console-window/

thanks!

Revision history for this message
Alejandro J. Cura (alecu) wrote :

The installer rebuilt by Brian worked as expected, so I guess this branch is ready to be approved.
On a related subject we should include the twisted patch on the installer being built by Jenkins.

Revision history for this message
Brian Curtin (brian.curtin) wrote :

When paired with that twisted branch, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/setup.py'
2--- scripts/setup.py 2012-05-10 21:49:51 +0000
3+++ scripts/setup.py 2012-06-01 04:10:23 +0000
4@@ -295,6 +295,9 @@
5 {
6 'script': 'bin/u1sdtool',
7 },
8+ {
9+ 'script': 'bin/ubuntuone-proxy-tunnel',
10+ },
11 ]
12
13 windows = [
14@@ -303,10 +306,6 @@
15 'icon_resources': [(0, 'ubuntu_one.ico')]
16 },
17 {
18- 'script': 'bin/ubuntuone-proxy-tunnel',
19- 'icon_resources': [(0, 'ubuntu_one.ico')]
20- },
21- {
22 'script': 'bin/ubuntuone-control-panel-qt',
23 'icon_resources': [(0, 'ubuntu_one.ico')]
24 },

Subscribers

People subscribed via source and target branches