Merge lp:~alecu/ubuntuone-client/the-other-signal into lp:ubuntuone-client

[Alejandro J. Cura]

Listen to the same DBus interface that Syncdaemon uses (LP: #759197)

Listen to the same DBus interface that Syncdaemon uses (LP: #759197)

[Alejandro J. Cura (alecu)]

This is a simpler way to fix Bug #759197, because the previous one broke a few things and had to be reverted.

[Alejandro J. Cura (alecu)]

To test this branch: create a new desktop user, log as it, check that there's no "Ubuntu One" bookmark on nautilus; then log into Ubuntu One (using a new or an existing user) and after logging into Ubuntu One the bookmark should be created.

[Natalia Bidart (nataliabidart)]

It works, code looks good.

review: Approve

[Alejandro J. Cura (alecu)]

To install this plugin: https://wiki.canonical.com/UbuntuOne/CodeReviewFaq#ubuntuone-client%20gnome-settings-daemon%20Plugin

[Roman Yepishev (rye)]

Works properly

review: Approve (fieldtest)

=== modified file 'libsyncdaemon/syncdaemon-authentication.c'
--- libsyncdaemon/syncdaemon-authentication.c	2011-04-18 20:39:30 +0000
+++ libsyncdaemon/syncdaemon-authentication.c	2011-04-18 20:39:30 +0000
@@ -31,6 +31,7 @@
 struct _SyncdaemonAuthenticationPrivate {
 	DBusGConnection *bus;
 	DBusGProxy *proxy;
+	DBusGProxy *newer_proxy;
 	gboolean has_credentials;
 	SyncdaemonCredentials *credentials;
 };
@@ -55,6 +56,8 @@
 			g_object_unref (G_OBJECT (auth->priv->credentials));
 		if (auth->priv->proxy != NULL)
 			g_object_unref (G_OBJECT (auth->priv->proxy));
+		if (auth->priv->newer_proxy != NULL)
+			g_object_unref (G_OBJECT (auth->priv->newer_proxy));
 		if (auth->priv->bus != NULL)
 			dbus_g_connection_unref (auth->priv->bus);
 
@@ -192,7 +195,30 @@
 			dbus_g_proxy_connect_signal (auth->priv->proxy, "CredentialsError",
 						     G_CALLBACK (credentials_error_cb), auth, NULL);
 		} else
-			g_warning ("Couldn't get proxy for com.ubuntu.sso");
+			g_warning ("Couldn't get proxy for com.ubuntu.sso.ApplicationCredentials");
+
+		auth->priv->newer_proxy = dbus_g_proxy_new_for_name (auth->priv->bus, "com.ubuntu.sso",
+							       "/com/ubuntu/sso/credentials", "com.ubuntu.sso.CredentialsManagement");
+		if (auth->priv->newer_proxy != NULL) {
+			dbus_g_object_register_marshaller (_syncdaemon_marshal_VOID__STRING_POINTER,
+							   G_TYPE_NONE,
+							   G_TYPE_STRING,
+							   dbus_g_type_get_map ("GHashTable",
+										G_TYPE_STRING,
+										G_TYPE_STRING),
+							   G_TYPE_INVALID);
+
+			dbus_g_proxy_add_signal (auth->priv->newer_proxy, "CredentialsFound",
+						 G_TYPE_STRING,
+						 dbus_g_type_get_map ("GHashTable",
+								      G_TYPE_STRING,
+								      G_TYPE_STRING),
+						 G_TYPE_INVALID);
+			dbus_g_proxy_connect_signal (auth->priv->newer_proxy, "CredentialsFound",
+						     G_CALLBACK (credentials_found_cb), auth, NULL);
+		} else
+			g_warning ("Couldn't get proxy for com.ubuntu.sso.CredentialsManagement");
+
 	}
 }