Merge lp:~alecu/ubuntuone-client/the-other-signal-stable into lp:ubuntuone-client

Proposed by Alejandro J. Cura
Status: Superseded
Proposed branch: lp:~alecu/ubuntuone-client/the-other-signal-stable
Merge into: lp:ubuntuone-client
Diff against target: 64 lines (+28/-2)
2 files modified
configure.ac (+1/-1)
libsyncdaemon/syncdaemon-authentication.c (+27/-1)
To merge this branch: bzr merge lp:~alecu/ubuntuone-client/the-other-signal-stable
Reviewer Review Type Date Requested Status
Roman Yepishev (community) code Approve
Review via email: mp+58316@code.launchpad.net

This proposal has been superseded by a proposal from 2011-04-19.

Commit message

Listen to the same DBus interface that Syncdaemon uses (LP: #759197)

Description of the change

Listen to the same DBus interface that Syncdaemon uses (LP: #759197)

To post a comment you must log in.
Revision history for this message
Roman Yepishev (rye) wrote :

The corresponding trunk version worked perfectly so approving.

review: Approve (code)

Unmerged revisions

960. By Alejandro J. Cura

Listen to the same DBus interface that Syncdaemon uses

959. By Alejandro J. Cura

Revert changes from revision 956

958. By dobey

[release] 1.6.1 ubuntuone-client

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2011-04-08 22:52:08 +0000
3+++ configure.ac 2011-04-19 14:45:42 +0000
4@@ -1,7 +1,7 @@
5 dnl Process this file with autoconf to produce a configure script.
6 AC_PREREQ(2.53)
7
8-AC_INIT([ubuntuone-client], [1.6.0])
9+AC_INIT([ubuntuone-client], [1.6.1])
10 AC_CONFIG_SRCDIR([config.h.in])
11
12 AM_INIT_AUTOMAKE([1.10 foreign])
13
14=== modified file 'libsyncdaemon/syncdaemon-authentication.c'
15--- libsyncdaemon/syncdaemon-authentication.c 2011-04-18 16:52:04 +0000
16+++ libsyncdaemon/syncdaemon-authentication.c 2011-04-19 14:45:42 +0000
17@@ -31,6 +31,7 @@
18 struct _SyncdaemonAuthenticationPrivate {
19 DBusGConnection *bus;
20 DBusGProxy *proxy;
21+ DBusGProxy *newer_proxy;
22 gboolean has_credentials;
23 SyncdaemonCredentials *credentials;
24 };
25@@ -55,6 +56,8 @@
26 g_object_unref (G_OBJECT (auth->priv->credentials));
27 if (auth->priv->proxy != NULL)
28 g_object_unref (G_OBJECT (auth->priv->proxy));
29+ if (auth->priv->newer_proxy != NULL)
30+ g_object_unref (G_OBJECT (auth->priv->newer_proxy));
31 if (auth->priv->bus != NULL)
32 dbus_g_connection_unref (auth->priv->bus);
33
34@@ -192,7 +195,30 @@
35 dbus_g_proxy_connect_signal (auth->priv->proxy, "CredentialsError",
36 G_CALLBACK (credentials_error_cb), auth, NULL);
37 } else
38- g_warning ("Couldn't get proxy for com.ubuntu.sso");
39+ g_warning ("Couldn't get proxy for com.ubuntu.sso.ApplicationCredentials");
40+
41+ auth->priv->newer_proxy = dbus_g_proxy_new_for_name (auth->priv->bus, "com.ubuntu.sso",
42+ "/com/ubuntu/sso/credentials", "com.ubuntu.sso.CredentialsManagement");
43+ if (auth->priv->newer_proxy != NULL) {
44+ dbus_g_object_register_marshaller (_syncdaemon_marshal_VOID__STRING_POINTER,
45+ G_TYPE_NONE,
46+ G_TYPE_STRING,
47+ dbus_g_type_get_map ("GHashTable",
48+ G_TYPE_STRING,
49+ G_TYPE_STRING),
50+ G_TYPE_INVALID);
51+
52+ dbus_g_proxy_add_signal (auth->priv->newer_proxy, "CredentialsFound",
53+ G_TYPE_STRING,
54+ dbus_g_type_get_map ("GHashTable",
55+ G_TYPE_STRING,
56+ G_TYPE_STRING),
57+ G_TYPE_INVALID);
58+ dbus_g_proxy_connect_signal (auth->priv->newer_proxy, "CredentialsFound",
59+ G_CALLBACK (credentials_found_cb), auth, NULL);
60+ } else
61+ g_warning ("Couldn't get proxy for com.ubuntu.sso.CredentialsManagement");
62+
63 }
64 }
65

Subscribers

People subscribed via source and target branches